Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22252 )
Change subject: WIP: refactor Frontend part 1 ...................................................................... Patch Set 2: (6 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/22252/2/fe/src/main/java/org/apache/impala/service/CoordinatorFrontendContextBuilder.java File fe/src/main/java/org/apache/impala/service/CoordinatorFrontendContextBuilder.java: http://gerrit.cloudera.org:8080/#/c/22252/2/fe/src/main/java/org/apache/impala/service/CoordinatorFrontendContextBuilder.java@251 PS2, Line 251: private AuthorizationFactory authzFactory_; line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22252/2/fe/src/main/java/org/apache/impala/service/CoordinatorFrontendContextBuilder.java@256 PS2, Line 256: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22252/2/fe/src/main/java/org/apache/impala/service/CoordinatorFrontendContextBuilder.java@269 PS2, Line 269: public CoordinatorFrontendContextBuilder(BackendConfig backendConfig) throws ImpalaException { line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/22252/2/fe/src/main/java/org/apache/impala/service/FrontendContext.java File fe/src/main/java/org/apache/impala/service/FrontendContext.java: http://gerrit.cloudera.org:8080/#/c/22252/2/fe/src/main/java/org/apache/impala/service/FrontendContext.java@293 PS2, Line 293: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22252/2/java/external-frontend/src/main/java/org/apache/impala/external/TestJniFrontend.java File java/external-frontend/src/main/java/org/apache/impala/external/TestJniFrontend.java: http://gerrit.cloudera.org:8080/#/c/22252/2/java/external-frontend/src/main/java/org/apache/impala/external/TestJniFrontend.java@87 PS2, Line 87: public TestFrontendContextBuilder(BackendConfig backendConfig) throws ImpalaException { line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/22252/2/java/test-frontend/src/main/java/org/apache/impala/service/BETestJniFrontend.java File java/test-frontend/src/main/java/org/apache/impala/service/BETestJniFrontend.java: http://gerrit.cloudera.org:8080/#/c/22252/2/java/test-frontend/src/main/java/org/apache/impala/service/BETestJniFrontend.java@257 PS2, Line 257: public TestFrontendContextBuilder(BackendConfig backendConfig) throws ImpalaException { line too long (91 > 90) -- To view, visit http://gerrit.cloudera.org:8080/22252 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idb8b54b8a2c36740bc6a10e8fec64dc70541327c Gerrit-Change-Number: 22252 Gerrit-PatchSet: 2 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Sat, 21 Dec 2024 04:38:29 +0000 Gerrit-HasComments: Yes
