Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22252 )
Change subject: WIP: refactor Frontend part 1 ...................................................................... Patch Set 10: (41 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/22252/10/fe/src/main/java/org/apache/impala/analysis/AnalysisDriverImpl.java File fe/src/main/java/org/apache/impala/analysis/AnalysisDriverImpl.java: http://gerrit.cloudera.org:8080/#/c/22252/10/fe/src/main/java/org/apache/impala/analysis/AnalysisDriverImpl.java@59 PS10, Line 59: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22252/10/fe/src/main/java/org/apache/impala/analysis/AnalysisDriverImpl.java@130 PS10, Line 130: if (requiresAcidComplexScanRewrite(analysisResult_.stmt_, analysisResult_.analyzer_)) { line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/22252/10/fe/src/main/java/org/apache/impala/analysis/AnalysisResult.java File fe/src/main/java/org/apache/impala/analysis/AnalysisResult.java: http://gerrit.cloudera.org:8080/#/c/22252/10/fe/src/main/java/org/apache/impala/analysis/AnalysisResult.java@59 PS10, Line 59: protected static final Logger LOG = LoggerFactory.getLogger(AnalysisResult.class.getName()); line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/22252/10/fe/src/main/java/org/apache/impala/analysis/CreateFunctionStmtBase.java File fe/src/main/java/org/apache/impala/analysis/CreateFunctionStmtBase.java: http://gerrit.cloudera.org:8080/#/c/22252/10/fe/src/main/java/org/apache/impala/analysis/CreateFunctionStmtBase.java@70 PS10, Line 70: protected CreateFunctionStmtBase(Set<StatementType> stmtTypes, FunctionName fnName, FunctionArgs args, line too long (104 > 90) http://gerrit.cloudera.org:8080/#/c/22252/10/fe/src/main/java/org/apache/impala/analysis/CreateOrAlterViewStmtBase.java File fe/src/main/java/org/apache/impala/analysis/CreateOrAlterViewStmtBase.java: http://gerrit.cloudera.org:8080/#/c/22252/10/fe/src/main/java/org/apache/impala/analysis/CreateOrAlterViewStmtBase.java@80 PS10, Line 80: public CreateOrAlterViewStmtBase(Set<StatementType> stmtTypes, boolean ifNotExists, TableName tableName, line too long (106 > 90) http://gerrit.cloudera.org:8080/#/c/22252/10/fe/src/main/java/org/apache/impala/analysis/DeleteStmt.java File fe/src/main/java/org/apache/impala/analysis/DeleteStmt.java: http://gerrit.cloudera.org:8080/#/c/22252/10/fe/src/main/java/org/apache/impala/analysis/DeleteStmt.java@47 PS10, Line 47: public class DeleteStmt extends ModifyStmt line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22252/10/fe/src/main/java/org/apache/impala/analysis/ModifyStmt.java File fe/src/main/java/org/apache/impala/analysis/ModifyStmt.java: http://gerrit.cloudera.org:8080/#/c/22252/10/fe/src/main/java/org/apache/impala/analysis/ModifyStmt.java@92 PS10, Line 92: public ModifyStmt(Set<StatementType> stmtTypes, List<String> targetTablePath, FromClause fromClause, line too long (102 > 90) http://gerrit.cloudera.org:8080/#/c/22252/10/fe/src/main/java/org/apache/impala/analysis/QueryStmt.java File fe/src/main/java/org/apache/impala/analysis/QueryStmt.java: http://gerrit.cloudera.org:8080/#/c/22252/10/fe/src/main/java/org/apache/impala/analysis/QueryStmt.java@105 PS10, Line 105: QueryStmt(Set<StatementType> stmtTypes, List<OrderByElement> orderByElements, LimitElement limitElement) { line too long (108 > 90) http://gerrit.cloudera.org:8080/#/c/22252/10/fe/src/main/java/org/apache/impala/analysis/ShowTablesOrViewsStmt.java File fe/src/main/java/org/apache/impala/analysis/ShowTablesOrViewsStmt.java: http://gerrit.cloudera.org:8080/#/c/22252/10/fe/src/main/java/org/apache/impala/analysis/ShowTablesOrViewsStmt.java@65 PS10, Line 65: public ShowTablesOrViewsStmt(Set<StatementType> stmtType, String database, String pattern) { line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/22252/10/fe/src/main/java/org/apache/impala/analysis/UpdateStmt.java File fe/src/main/java/org/apache/impala/analysis/UpdateStmt.java: http://gerrit.cloudera.org:8080/#/c/22252/10/fe/src/main/java/org/apache/impala/analysis/UpdateStmt.java@68 PS10, Line 68: StatementType.DML); line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22252/10/fe/src/main/java/org/apache/impala/planner/Planner.java File fe/src/main/java/org/apache/impala/planner/Planner.java: http://gerrit.cloudera.org:8080/#/c/22252/10/fe/src/main/java/org/apache/impala/planner/Planner.java@357 PS10, Line 357: if (ctx_.getAnalysisResult().getStmt().isExplain() || RuntimeEnv.INSTANCE.isTestEnv()) { line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/22252/10/fe/src/main/java/org/apache/impala/planner/PlannerContext.java File fe/src/main/java/org/apache/impala/planner/PlannerContext.java: http://gerrit.cloudera.org:8080/#/c/22252/10/fe/src/main/java/org/apache/impala/planner/PlannerContext.java@112 PS10, Line 112: public boolean isOptimize() { return analysisResult_.getStmt().isStmtType(StatementType.OPTIMIZE);} line too long (101 > 90) http://gerrit.cloudera.org:8080/#/c/22252/10/fe/src/main/java/org/apache/impala/service/BETestJniFrontend.java File fe/src/main/java/org/apache/impala/service/BETestJniFrontend.java: http://gerrit.cloudera.org:8080/#/c/22252/10/fe/src/main/java/org/apache/impala/service/BETestJniFrontend.java@258 PS10, Line 258: public TestTransactionContextBuilder(BackendConfig backendConfig) throws ImpalaException { line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/22252/10/fe/src/main/java/org/apache/impala/service/CoordinatorFrontendContextBuilder.java File fe/src/main/java/org/apache/impala/service/CoordinatorFrontendContextBuilder.java: http://gerrit.cloudera.org:8080/#/c/22252/10/fe/src/main/java/org/apache/impala/service/CoordinatorFrontendContextBuilder.java@251 PS10, Line 251: private AuthorizationFactory authzFactory_; line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22252/10/fe/src/main/java/org/apache/impala/service/CoordinatorFrontendContextBuilder.java@256 PS10, Line 256: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22252/10/fe/src/main/java/org/apache/impala/service/CoordinatorFrontendContextBuilder.java@269 PS10, Line 269: public CoordinatorFrontendContextBuilder(BackendConfig backendConfig) throws ImpalaException { line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/22252/10/fe/src/main/java/org/apache/impala/service/FrontendContext.java File fe/src/main/java/org/apache/impala/service/FrontendContext.java: http://gerrit.cloudera.org:8080/#/c/22252/10/fe/src/main/java/org/apache/impala/service/FrontendContext.java@281 PS10, Line 281: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22252/10/fe/src/main/java/org/apache/impala/stmtdriver/StmtDriver.java File fe/src/main/java/org/apache/impala/stmtdriver/StmtDriver.java: http://gerrit.cloudera.org:8080/#/c/22252/10/fe/src/main/java/org/apache/impala/stmtdriver/StmtDriver.java@681 PS10, Line 681: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22252/10/fe/src/main/java/org/apache/impala/stmtdriver/StmtDriver.java@703 PS10, Line 703: analysisResult.getStmt().isStmtType(StatementType.CREATE_TABLE_AS_SELECT))) { line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/22252/10/fe/src/main/java/org/apache/impala/stmtdriver/StmtDriver.java@721 PS10, Line 721: transaction_.createLockForInsert(txnId, tables, targetTable, insertStmt.isOverwrite(), line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/22252/10/fe/src/main/java/org/apache/impala/stmtdriver/StmtDriver.java@778 PS10, Line 778: if (!analysisResult.getStmt().isExplain() && queryOptions.isEnable_kudu_transaction()) { line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/22252/10/fe/src/main/java/org/apache/impala/stmtdriver/StmtDriver.java@833 PS10, Line 833: result.stmt_type = analysisResult.getStmt().isStmtType(StatementType.CREATE_TABLE_AS_SELECT) line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/22252/10/fe/src/main/java/org/apache/impala/stmtdriver/StmtDriver.java@926 PS10, Line 926: StatementType.unwrapStmt(ShowDataSrcsStmt.class, analysis.getStmt()).toThrift()); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/22252/10/fe/src/main/java/org/apache/impala/stmtdriver/StmtDriver.java@1086 PS10, Line 1086: StatementType.unwrapStmt(ComputeStatsStmt.class, analysis.getStmt()).toThrift()); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/22252/10/fe/src/main/java/org/apache/impala/stmtdriver/Transaction.java File fe/src/main/java/org/apache/impala/stmtdriver/Transaction.java: http://gerrit.cloudera.org:8080/#/c/22252/10/fe/src/main/java/org/apache/impala/stmtdriver/Transaction.java@253 PS10, Line 253: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22252/10/fe/src/main/java/org/apache/impala/stmtdriver/TransactionContext.java File fe/src/main/java/org/apache/impala/stmtdriver/TransactionContext.java: http://gerrit.cloudera.org:8080/#/c/22252/10/fe/src/main/java/org/apache/impala/stmtdriver/TransactionContext.java@278 PS10, Line 278: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22252/10/fe/src/test/java/org/apache/impala/analysis/AuditingTest.java File fe/src/test/java/org/apache/impala/analysis/AuditingTest.java: http://gerrit.cloudera.org:8080/#/c/22252/10/fe/src/test/java/org/apache/impala/analysis/AuditingTest.java@411 PS10, Line 411: TransactionContext.Builder transactionContextBuilder = new TransactionContext.Builder( line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/22252/10/fe/src/test/java/org/apache/impala/analysis/ParserTest.java File fe/src/test/java/org/apache/impala/analysis/ParserTest.java: http://gerrit.cloudera.org:8080/#/c/22252/10/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@372 PS10, Line 372: CreateTableAsSelectStmt ctasStmt = (CreateTableAsSelectStmt) parsedStmt.getTopLevelNode(); line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/22252/10/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@1719 PS10, Line 1719: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22252/10/fe/src/test/java/org/apache/impala/analysis/StmtMetadataLoaderTest.java File fe/src/test/java/org/apache/impala/analysis/StmtMetadataLoaderTest.java: http://gerrit.cloudera.org:8080/#/c/22252/10/fe/src/test/java/org/apache/impala/analysis/StmtMetadataLoaderTest.java@61 PS10, Line 61: TransactionContext.Builder transactionContextBuilder = new TransactionContext.Builder( line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/22252/10/fe/src/test/java/org/apache/impala/analysis/StmtMetadataLoaderTest.java@79 PS10, Line 79: TransactionContext.Builder transactionContextBuilder = new TransactionContext.Builder( line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/22252/10/fe/src/test/java/org/apache/impala/analysis/StmtMetadataLoaderTest.java@94 PS10, Line 94: TransactionContext.Builder transactionContextBuilder = new TransactionContext.Builder( line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/22252/10/fe/src/test/java/org/apache/impala/authorization/AuthorizationTestBase.java File fe/src/test/java/org/apache/impala/authorization/AuthorizationTestBase.java: http://gerrit.cloudera.org:8080/#/c/22252/10/fe/src/test/java/org/apache/impala/authorization/AuthorizationTestBase.java@138 PS10, Line 138: TransactionContext.Builder transactionContextBuilder = new TransactionContext.Builder( line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/22252/10/fe/src/test/java/org/apache/impala/common/FrontendFixture.java File fe/src/test/java/org/apache/impala/common/FrontendFixture.java: http://gerrit.cloudera.org:8080/#/c/22252/10/fe/src/test/java/org/apache/impala/common/FrontendFixture.java@270 PS10, Line 270: QueryStmt viewStmt = (QueryStmt) parseStmt(createViewStmt.getInlineViewDef()).getTopLevelNode(); line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/22252/10/fe/src/test/java/org/apache/impala/common/FrontendFixture.java@377 PS10, Line 377: TestParsedStatement parsedStmt = new TestParsedStatement(stmt, ctx.getQueryCtx().client_request.query_options); line too long (115 > 90) http://gerrit.cloudera.org:8080/#/c/22252/10/fe/src/test/java/org/apache/impala/common/FrontendTestBase.java File fe/src/test/java/org/apache/impala/common/FrontendTestBase.java: http://gerrit.cloudera.org:8080/#/c/22252/10/fe/src/test/java/org/apache/impala/common/FrontendTestBase.java@85 PS10, Line 85: protected static final Logger LOG = LoggerFactory.getLogger(FrontendTestBase.class.getName()); line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/22252/10/fe/src/test/java/org/apache/impala/common/TestParsedStatement.java File fe/src/test/java/org/apache/impala/common/TestParsedStatement.java: http://gerrit.cloudera.org:8080/#/c/22252/10/fe/src/test/java/org/apache/impala/common/TestParsedStatement.java@55 PS10, Line 55: protected static final Logger LOG = LoggerFactory.getLogger(TestParsedStatement.class.getName()); line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/22252/10/fe/src/test/java/org/apache/impala/common/TestParsedStatement.java@72 PS10, Line 72: stmt_ = Parser.parse(stmtSql); line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22252/10/fe/src/test/java/org/apache/impala/common/TestParsedStatement.java@80 PS10, Line 80: @Override line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22252/10/java/external-frontend/src/main/java/org/apache/impala/external/TestJniFrontend.java File java/external-frontend/src/main/java/org/apache/impala/external/TestJniFrontend.java: http://gerrit.cloudera.org:8080/#/c/22252/10/java/external-frontend/src/main/java/org/apache/impala/external/TestJniFrontend.java@88 PS10, Line 88: public TestTransactionContextBuilder(BackendConfig backendConfig) throws ImpalaException { line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/22252/10/java/test-frontend/src/main/java/org/apache/impala/service/BETestJniFrontend.java File java/test-frontend/src/main/java/org/apache/impala/service/BETestJniFrontend.java: http://gerrit.cloudera.org:8080/#/c/22252/10/java/test-frontend/src/main/java/org/apache/impala/service/BETestJniFrontend.java@257 PS10, Line 257: public TestTransactionContextBuilder(BackendConfig backendConfig) throws ImpalaException { line too long (94 > 90) -- To view, visit http://gerrit.cloudera.org:8080/22252 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idb8b54b8a2c36740bc6a10e8fec64dc70541327c Gerrit-Change-Number: 22252 Gerrit-PatchSet: 10 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Fri, 27 Dec 2024 05:08:10 +0000 Gerrit-HasComments: Yes
