Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22264 )
Change subject: IMPALA-13305: Better thrift compatability checks based on pyparsing ...................................................................... Patch Set 1: (29 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/22264/1/bin/jenkins/critique-gerrit-review.py File bin/jenkins/critique-gerrit-review.py: http://gerrit.cloudera.org:8080/#/c/22264/1/bin/jenkins/critique-gerrit-review.py@308 PS1, Line 308: + flake8: W504 line break after binary operator http://gerrit.cloudera.org:8080/#/c/22264/1/bin/jenkins/critique-gerrit-review.py@315 PS1, Line 315: + flake8: W504 line break after binary operator http://gerrit.cloudera.org:8080/#/c/22264/1/bin/jenkins/critique-gerrit-review.py@334 PS1, Line 334: + flake8: W504 line break after binary operator http://gerrit.cloudera.org:8080/#/c/22264/1/bin/jenkins/critique-gerrit-review.py@354 PS1, Line 354: + flake8: W504 line break after binary operator http://gerrit.cloudera.org:8080/#/c/22264/1/bin/jenkins/critique-gerrit-review.py@361 PS1, Line 361: + flake8: W504 line break after binary operator http://gerrit.cloudera.org:8080/#/c/22264/1/bin/jenkins/thrift_parser.py File bin/jenkins/thrift_parser.py: http://gerrit.cloudera.org:8080/#/c/22264/1/bin/jenkins/thrift_parser.py@27 PS1, Line 27: from pyparsing import ( flake8: F401 'pyparsing.Keyword' imported but unused http://gerrit.cloudera.org:8080/#/c/22264/1/bin/jenkins/thrift_parser.py@27 PS1, Line 27: from pyparsing import ( flake8: F401 'pyparsing.Dict' imported but unused http://gerrit.cloudera.org:8080/#/c/22264/1/bin/jenkins/thrift_parser.py@57 PS1, Line 57: flake8: W291 trailing whitespace http://gerrit.cloudera.org:8080/#/c/22264/1/bin/jenkins/thrift_parser.py@57 PS1, Line 57: kwds = """typedef namespace exception struct union required optional enum extends line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22264/1/bin/jenkins/thrift_parser.py@65 PS1, Line 65: L flake8: F821 undefined name 'LIST_' http://gerrit.cloudera.org:8080/#/c/22264/1/bin/jenkins/thrift_parser.py@65 PS1, Line 65: S flake8: F821 undefined name 'SET_' http://gerrit.cloudera.org:8080/#/c/22264/1/bin/jenkins/thrift_parser.py@66 PS1, Line 66: M flake8: F821 undefined name 'MAP_' http://gerrit.cloudera.org:8080/#/c/22264/1/bin/jenkins/thrift_parser.py@71 PS1, Line 71: T flake8: F821 undefined name 'TRUE_' http://gerrit.cloudera.org:8080/#/c/22264/1/bin/jenkins/thrift_parser.py@71 PS1, Line 71: F flake8: F821 undefined name 'FALSE_' http://gerrit.cloudera.org:8080/#/c/22264/1/bin/jenkins/thrift_parser.py@86 PS1, Line 86: def create_thrift_field(src_string, locn, toks): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/22264/1/bin/jenkins/thrift_parser.py@94 PS1, Line 94: fieldDefn = ( flake8: E305 expected 2 blank lines after class or function definition, found 1 http://gerrit.cloudera.org:8080/#/c/22264/1/bin/jenkins/thrift_parser.py@97 PS1, Line 97: R flake8: F821 undefined name 'REQUIRED_' http://gerrit.cloudera.org:8080/#/c/22264/1/bin/jenkins/thrift_parser.py@97 PS1, Line 97: O flake8: F821 undefined name 'OPTIONAL_' http://gerrit.cloudera.org:8080/#/c/22264/1/bin/jenkins/thrift_parser.py@106 PS1, Line 106: S flake8: F821 undefined name 'STRUCT_' http://gerrit.cloudera.org:8080/#/c/22264/1/bin/jenkins/thrift_parser.py@108 PS1, Line 108: U flake8: F821 undefined name 'UNION_' http://gerrit.cloudera.org:8080/#/c/22264/1/bin/jenkins/thrift_parser.py@110 PS1, Line 110: class ThriftEnumItem: flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/22264/1/bin/jenkins/thrift_parser.py@119 PS1, Line 119: def create_thrift_enum_item(src_string, locn, toks): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/22264/1/bin/jenkins/thrift_parser.py@124 PS1, Line 124: enumDefn = ( flake8: E305 expected 2 blank lines after class or function definition, found 1 http://gerrit.cloudera.org:8080/#/c/22264/1/bin/jenkins/thrift_parser.py@125 PS1, Line 125: E flake8: F821 undefined name 'ENUM_' http://gerrit.cloudera.org:8080/#/c/22264/1/bin/jenkins/thrift_parser.py@142 PS1, Line 142: T flake8: F821 undefined name 'THROWS_' http://gerrit.cloudera.org:8080/#/c/22264/1/bin/jenkins/thrift_parser.py@148 PS1, Line 148: S flake8: F821 undefined name 'SERVICE_' http://gerrit.cloudera.org:8080/#/c/22264/1/bin/jenkins/thrift_parser.py@148 PS1, Line 148: E flake8: F821 undefined name 'EXTENDS_' http://gerrit.cloudera.org:8080/#/c/22264/1/bin/jenkins/thrift_parser.py@151 PS1, Line 151: T flake8: F821 undefined name 'TYPEDEF_' http://gerrit.cloudera.org:8080/#/c/22264/1/bin/jenkins/thrift_parser.py@183 PS1, Line 183: flake8: W292 no newline at end of file -- To view, visit http://gerrit.cloudera.org:8080/22264 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia1dc4112404d0e7c5df94ee9f59a4fe2084b360d Gerrit-Change-Number: 22264 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Sun, 29 Dec 2024 07:37:08 +0000 Gerrit-HasComments: Yes
