Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22267 )
Change subject: WIP: cleaned up AnalysisResult a bit. ...................................................................... Patch Set 1: (16 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/22267/1/fe/src/main/java/org/apache/impala/analysis/AnalysisDriverImpl.java File fe/src/main/java/org/apache/impala/analysis/AnalysisDriverImpl.java: http://gerrit.cloudera.org:8080/#/c/22267/1/fe/src/main/java/org/apache/impala/analysis/AnalysisDriverImpl.java@130 PS1, Line 130: if (requiresAcidComplexScanRewrite(analysisResult_.stmt_, analysisResult_.analyzer_)) { line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/22267/1/fe/src/main/java/org/apache/impala/analysis/AnalysisResult.java File fe/src/main/java/org/apache/impala/analysis/AnalysisResult.java: http://gerrit.cloudera.org:8080/#/c/22267/1/fe/src/main/java/org/apache/impala/analysis/AnalysisResult.java@59 PS1, Line 59: protected static final Logger LOG = LoggerFactory.getLogger(AnalysisResult.class.getName()); line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/22267/1/fe/src/main/java/org/apache/impala/analysis/CreateFunctionStmtBase.java File fe/src/main/java/org/apache/impala/analysis/CreateFunctionStmtBase.java: http://gerrit.cloudera.org:8080/#/c/22267/1/fe/src/main/java/org/apache/impala/analysis/CreateFunctionStmtBase.java@70 PS1, Line 70: protected CreateFunctionStmtBase(Set<StatementType> stmtTypes, FunctionName fnName, FunctionArgs args, line too long (104 > 90) http://gerrit.cloudera.org:8080/#/c/22267/1/fe/src/main/java/org/apache/impala/analysis/CreateOrAlterViewStmtBase.java File fe/src/main/java/org/apache/impala/analysis/CreateOrAlterViewStmtBase.java: http://gerrit.cloudera.org:8080/#/c/22267/1/fe/src/main/java/org/apache/impala/analysis/CreateOrAlterViewStmtBase.java@80 PS1, Line 80: public CreateOrAlterViewStmtBase(Set<StatementType> stmtTypes, boolean ifNotExists, TableName tableName, line too long (106 > 90) http://gerrit.cloudera.org:8080/#/c/22267/1/fe/src/main/java/org/apache/impala/analysis/DeleteStmt.java File fe/src/main/java/org/apache/impala/analysis/DeleteStmt.java: http://gerrit.cloudera.org:8080/#/c/22267/1/fe/src/main/java/org/apache/impala/analysis/DeleteStmt.java@47 PS1, Line 47: public class DeleteStmt extends ModifyStmt line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22267/1/fe/src/main/java/org/apache/impala/analysis/ModifyStmt.java File fe/src/main/java/org/apache/impala/analysis/ModifyStmt.java: http://gerrit.cloudera.org:8080/#/c/22267/1/fe/src/main/java/org/apache/impala/analysis/ModifyStmt.java@92 PS1, Line 92: public ModifyStmt(Set<StatementType> stmtTypes, List<String> targetTablePath, FromClause fromClause, line too long (102 > 90) http://gerrit.cloudera.org:8080/#/c/22267/1/fe/src/main/java/org/apache/impala/analysis/QueryStmt.java File fe/src/main/java/org/apache/impala/analysis/QueryStmt.java: http://gerrit.cloudera.org:8080/#/c/22267/1/fe/src/main/java/org/apache/impala/analysis/QueryStmt.java@104 PS1, Line 104: QueryStmt(Set<StatementType> stmtTypes, List<OrderByElement> orderByElements, LimitElement limitElement) { line too long (108 > 90) http://gerrit.cloudera.org:8080/#/c/22267/1/fe/src/main/java/org/apache/impala/analysis/ShowTablesOrViewsStmt.java File fe/src/main/java/org/apache/impala/analysis/ShowTablesOrViewsStmt.java: http://gerrit.cloudera.org:8080/#/c/22267/1/fe/src/main/java/org/apache/impala/analysis/ShowTablesOrViewsStmt.java@65 PS1, Line 65: public ShowTablesOrViewsStmt(Set<StatementType> stmtType, String database, String pattern) { line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/22267/1/fe/src/main/java/org/apache/impala/analysis/UpdateStmt.java File fe/src/main/java/org/apache/impala/analysis/UpdateStmt.java: http://gerrit.cloudera.org:8080/#/c/22267/1/fe/src/main/java/org/apache/impala/analysis/UpdateStmt.java@68 PS1, Line 68: StatementType.DML); line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22267/1/fe/src/main/java/org/apache/impala/planner/Planner.java File fe/src/main/java/org/apache/impala/planner/Planner.java: http://gerrit.cloudera.org:8080/#/c/22267/1/fe/src/main/java/org/apache/impala/planner/Planner.java@357 PS1, Line 357: if (ctx_.getAnalysisResult().getStmt().isExplain() || RuntimeEnv.INSTANCE.isTestEnv()) { line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/22267/1/fe/src/main/java/org/apache/impala/planner/PlannerContext.java File fe/src/main/java/org/apache/impala/planner/PlannerContext.java: http://gerrit.cloudera.org:8080/#/c/22267/1/fe/src/main/java/org/apache/impala/planner/PlannerContext.java@112 PS1, Line 112: public boolean isOptimize() { return analysisResult_.getStmt().isStmtType(StatementType.OPTIMIZE);} line too long (101 > 90) http://gerrit.cloudera.org:8080/#/c/22267/1/fe/src/main/java/org/apache/impala/stmtdriver/StmtDriver.java File fe/src/main/java/org/apache/impala/stmtdriver/StmtDriver.java: http://gerrit.cloudera.org:8080/#/c/22267/1/fe/src/main/java/org/apache/impala/stmtdriver/StmtDriver.java@703 PS1, Line 703: analysisResult.getStmt().isStmtType(StatementType.CREATE_TABLE_AS_SELECT))) { line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/22267/1/fe/src/main/java/org/apache/impala/stmtdriver/StmtDriver.java@778 PS1, Line 778: if (!analysisResult.getStmt().isExplain() && queryOptions.isEnable_kudu_transaction()) { line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/22267/1/fe/src/main/java/org/apache/impala/stmtdriver/StmtDriver.java@833 PS1, Line 833: result.stmt_type = analysisResult.getStmt().isStmtType(StatementType.CREATE_TABLE_AS_SELECT) line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/22267/1/fe/src/main/java/org/apache/impala/stmtdriver/StmtDriver.java@926 PS1, Line 926: StatementType.unwrapStmt(ShowDataSrcsStmt.class, analysis.getStmt()).toThrift()); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/22267/1/fe/src/main/java/org/apache/impala/stmtdriver/StmtDriver.java@1086 PS1, Line 1086: StatementType.unwrapStmt(ComputeStatsStmt.class, analysis.getStmt()).toThrift()); line too long (91 > 90) -- To view, visit http://gerrit.cloudera.org:8080/22267 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5682a5403f557b59344bd8a5ea4d86bd5d30d22b Gerrit-Change-Number: 22267 Gerrit-PatchSet: 1 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Sun, 29 Dec 2024 15:33:31 +0000 Gerrit-HasComments: Yes
