Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22252 )
Change subject: WIP: refactor Frontend part 1 ...................................................................... Patch Set 18: (43 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/22252/18/fe/src/main/java/org/apache/impala/analysis/AnalysisDriverImpl.java File fe/src/main/java/org/apache/impala/analysis/AnalysisDriverImpl.java: http://gerrit.cloudera.org:8080/#/c/22252/18/fe/src/main/java/org/apache/impala/analysis/AnalysisDriverImpl.java@59 PS18, Line 59: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22252/18/fe/src/main/java/org/apache/impala/analysis/AnalysisDriverImpl.java@130 PS18, Line 130: if (requiresAcidComplexScanRewrite(analysisResult_.stmt_, analysisResult_.analyzer_)) { line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/22252/18/fe/src/main/java/org/apache/impala/analysis/AnalysisResult.java File fe/src/main/java/org/apache/impala/analysis/AnalysisResult.java: http://gerrit.cloudera.org:8080/#/c/22252/18/fe/src/main/java/org/apache/impala/analysis/AnalysisResult.java@59 PS18, Line 59: protected static final Logger LOG = LoggerFactory.getLogger(AnalysisResult.class.getName()); line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/22252/18/fe/src/main/java/org/apache/impala/analysis/CreateFunctionStmtBase.java File fe/src/main/java/org/apache/impala/analysis/CreateFunctionStmtBase.java: http://gerrit.cloudera.org:8080/#/c/22252/18/fe/src/main/java/org/apache/impala/analysis/CreateFunctionStmtBase.java@70 PS18, Line 70: protected CreateFunctionStmtBase(Set<StatementType> stmtTypes, FunctionName fnName, FunctionArgs args, line too long (104 > 90) http://gerrit.cloudera.org:8080/#/c/22252/18/fe/src/main/java/org/apache/impala/analysis/CreateOrAlterViewStmtBase.java File fe/src/main/java/org/apache/impala/analysis/CreateOrAlterViewStmtBase.java: http://gerrit.cloudera.org:8080/#/c/22252/18/fe/src/main/java/org/apache/impala/analysis/CreateOrAlterViewStmtBase.java@80 PS18, Line 80: public CreateOrAlterViewStmtBase(Set<StatementType> stmtTypes, boolean ifNotExists, TableName tableName, line too long (106 > 90) http://gerrit.cloudera.org:8080/#/c/22252/18/fe/src/main/java/org/apache/impala/analysis/DeleteStmt.java File fe/src/main/java/org/apache/impala/analysis/DeleteStmt.java: http://gerrit.cloudera.org:8080/#/c/22252/18/fe/src/main/java/org/apache/impala/analysis/DeleteStmt.java@48 PS18, Line 48: public class DeleteStmt extends ModifyStmt line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22252/18/fe/src/main/java/org/apache/impala/analysis/DescribeDbStmt.java File fe/src/main/java/org/apache/impala/analysis/DescribeDbStmt.java: http://gerrit.cloudera.org:8080/#/c/22252/18/fe/src/main/java/org/apache/impala/analysis/DescribeDbStmt.java@112 PS18, Line 112: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22252/18/fe/src/main/java/org/apache/impala/analysis/ModifyStmt.java File fe/src/main/java/org/apache/impala/analysis/ModifyStmt.java: http://gerrit.cloudera.org:8080/#/c/22252/18/fe/src/main/java/org/apache/impala/analysis/ModifyStmt.java@92 PS18, Line 92: public ModifyStmt(Set<StatementType> stmtTypes, List<String> targetTablePath, FromClause fromClause, line too long (102 > 90) http://gerrit.cloudera.org:8080/#/c/22252/18/fe/src/main/java/org/apache/impala/analysis/QueryStmt.java File fe/src/main/java/org/apache/impala/analysis/QueryStmt.java: http://gerrit.cloudera.org:8080/#/c/22252/18/fe/src/main/java/org/apache/impala/analysis/QueryStmt.java@107 PS18, Line 107: QueryStmt(Set<StatementType> stmtTypes, List<OrderByElement> orderByElements, LimitElement limitElement) { line too long (108 > 90) http://gerrit.cloudera.org:8080/#/c/22252/18/fe/src/main/java/org/apache/impala/analysis/ShowTablesOrViewsStmt.java File fe/src/main/java/org/apache/impala/analysis/ShowTablesOrViewsStmt.java: http://gerrit.cloudera.org:8080/#/c/22252/18/fe/src/main/java/org/apache/impala/analysis/ShowTablesOrViewsStmt.java@65 PS18, Line 65: public ShowTablesOrViewsStmt(Set<StatementType> stmtType, String database, String pattern) { line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/22252/18/fe/src/main/java/org/apache/impala/analysis/StatementBase.java File fe/src/main/java/org/apache/impala/analysis/StatementBase.java: http://gerrit.cloudera.org:8080/#/c/22252/18/fe/src/main/java/org/apache/impala/analysis/StatementBase.java@301 PS18, Line 301: public TCatalogOpRequest getTCatalogOpRequest(TQueryOptions queryOptions) line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22252/18/fe/src/main/java/org/apache/impala/analysis/UpdateStmt.java File fe/src/main/java/org/apache/impala/analysis/UpdateStmt.java: http://gerrit.cloudera.org:8080/#/c/22252/18/fe/src/main/java/org/apache/impala/analysis/UpdateStmt.java@69 PS18, Line 69: StatementType.DML); line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22252/18/fe/src/main/java/org/apache/impala/planner/Planner.java File fe/src/main/java/org/apache/impala/planner/Planner.java: http://gerrit.cloudera.org:8080/#/c/22252/18/fe/src/main/java/org/apache/impala/planner/Planner.java@357 PS18, Line 357: if (ctx_.getAnalysisResult().getStmt().isExplain() || RuntimeEnv.INSTANCE.isTestEnv()) { line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/22252/18/fe/src/main/java/org/apache/impala/planner/PlannerContext.java File fe/src/main/java/org/apache/impala/planner/PlannerContext.java: http://gerrit.cloudera.org:8080/#/c/22252/18/fe/src/main/java/org/apache/impala/planner/PlannerContext.java@112 PS18, Line 112: public boolean isOptimize() { return analysisResult_.getStmt().isStmtType(StatementType.OPTIMIZE);} line too long (101 > 90) http://gerrit.cloudera.org:8080/#/c/22252/18/fe/src/main/java/org/apache/impala/planner/PlannerDriver.java File fe/src/main/java/org/apache/impala/planner/PlannerDriver.java: http://gerrit.cloudera.org:8080/#/c/22252/18/fe/src/main/java/org/apache/impala/planner/PlannerDriver.java@413 PS18, Line 413: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22252/18/fe/src/main/java/org/apache/impala/service/BETestJniFrontend.java File fe/src/main/java/org/apache/impala/service/BETestJniFrontend.java: http://gerrit.cloudera.org:8080/#/c/22252/18/fe/src/main/java/org/apache/impala/service/BETestJniFrontend.java@258 PS18, Line 258: public TestTransactionContextBuilder(BackendConfig backendConfig) throws ImpalaException { line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/22252/18/fe/src/main/java/org/apache/impala/service/CoordinatorFrontendContextBuilder.java File fe/src/main/java/org/apache/impala/service/CoordinatorFrontendContextBuilder.java: http://gerrit.cloudera.org:8080/#/c/22252/18/fe/src/main/java/org/apache/impala/service/CoordinatorFrontendContextBuilder.java@251 PS18, Line 251: private AuthorizationFactory authzFactory_; line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22252/18/fe/src/main/java/org/apache/impala/service/CoordinatorFrontendContextBuilder.java@256 PS18, Line 256: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22252/18/fe/src/main/java/org/apache/impala/service/CoordinatorFrontendContextBuilder.java@269 PS18, Line 269: public CoordinatorFrontendContextBuilder(BackendConfig backendConfig) throws ImpalaException { line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/22252/18/fe/src/main/java/org/apache/impala/service/FrontendContext.java File fe/src/main/java/org/apache/impala/service/FrontendContext.java: http://gerrit.cloudera.org:8080/#/c/22252/18/fe/src/main/java/org/apache/impala/service/FrontendContext.java@281 PS18, Line 281: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22252/18/fe/src/main/java/org/apache/impala/stmtdriver/StmtDriver.java File fe/src/main/java/org/apache/impala/stmtdriver/StmtDriver.java: http://gerrit.cloudera.org:8080/#/c/22252/18/fe/src/main/java/org/apache/impala/stmtdriver/StmtDriver.java@650 PS18, Line 650: // for debugging, can line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22252/18/fe/src/main/java/org/apache/impala/stmtdriver/StmtDriver.java@684 PS18, Line 684: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22252/18/fe/src/main/java/org/apache/impala/stmtdriver/StmtDriver.java@696 PS18, Line 696: analysisResult.getStmt().isStmtType(StatementType.CREATE_TABLE_AS_SELECT))) { line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/22252/18/fe/src/main/java/org/apache/impala/stmtdriver/StmtDriver.java@714 PS18, Line 714: transaction_.createLockForInsert(txnId, tables, targetTable, insertStmt.isOverwrite(), line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/22252/18/fe/src/main/java/org/apache/impala/stmtdriver/StmtDriver.java@727 PS18, Line 727: if (!analysisResult.getStmt().isExplain() && queryOptions.isEnable_kudu_transaction()) { line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/22252/18/fe/src/main/java/org/apache/impala/stmtdriver/StmtDriver.java@773 PS18, Line 773: result.stmt_type = analysisResult.getStmt().isStmtType(StatementType.CREATE_TABLE_AS_SELECT) line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/22252/18/fe/src/main/java/org/apache/impala/stmtdriver/Transaction.java File fe/src/main/java/org/apache/impala/stmtdriver/Transaction.java: http://gerrit.cloudera.org:8080/#/c/22252/18/fe/src/main/java/org/apache/impala/stmtdriver/Transaction.java@253 PS18, Line 253: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22252/18/fe/src/main/java/org/apache/impala/stmtdriver/TransactionContext.java File fe/src/main/java/org/apache/impala/stmtdriver/TransactionContext.java: http://gerrit.cloudera.org:8080/#/c/22252/18/fe/src/main/java/org/apache/impala/stmtdriver/TransactionContext.java@278 PS18, Line 278: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22252/18/fe/src/test/java/org/apache/impala/analysis/AuditingTest.java File fe/src/test/java/org/apache/impala/analysis/AuditingTest.java: http://gerrit.cloudera.org:8080/#/c/22252/18/fe/src/test/java/org/apache/impala/analysis/AuditingTest.java@411 PS18, Line 411: TransactionContext.Builder transactionContextBuilder = new TransactionContext.Builder( line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/22252/18/fe/src/test/java/org/apache/impala/analysis/ParserTest.java File fe/src/test/java/org/apache/impala/analysis/ParserTest.java: http://gerrit.cloudera.org:8080/#/c/22252/18/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@372 PS18, Line 372: CreateTableAsSelectStmt ctasStmt = (CreateTableAsSelectStmt) parsedStmt.getTopLevelNode(); line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/22252/18/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@1719 PS18, Line 1719: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22252/18/fe/src/test/java/org/apache/impala/analysis/StmtMetadataLoaderTest.java File fe/src/test/java/org/apache/impala/analysis/StmtMetadataLoaderTest.java: http://gerrit.cloudera.org:8080/#/c/22252/18/fe/src/test/java/org/apache/impala/analysis/StmtMetadataLoaderTest.java@63 PS18, Line 63: TransactionContext.Builder transactionContextBuilder = new TransactionContext.Builder( line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/22252/18/fe/src/test/java/org/apache/impala/analysis/StmtMetadataLoaderTest.java@81 PS18, Line 81: TransactionContext.Builder transactionContextBuilder = new TransactionContext.Builder( line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/22252/18/fe/src/test/java/org/apache/impala/analysis/StmtMetadataLoaderTest.java@96 PS18, Line 96: TransactionContext.Builder transactionContextBuilder = new TransactionContext.Builder( line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/22252/18/fe/src/test/java/org/apache/impala/authorization/AuthorizationTestBase.java File fe/src/test/java/org/apache/impala/authorization/AuthorizationTestBase.java: http://gerrit.cloudera.org:8080/#/c/22252/18/fe/src/test/java/org/apache/impala/authorization/AuthorizationTestBase.java@138 PS18, Line 138: TransactionContext.Builder transactionContextBuilder = new TransactionContext.Builder( line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/22252/18/fe/src/test/java/org/apache/impala/common/FrontendFixture.java File fe/src/test/java/org/apache/impala/common/FrontendFixture.java: http://gerrit.cloudera.org:8080/#/c/22252/18/fe/src/test/java/org/apache/impala/common/FrontendFixture.java@270 PS18, Line 270: QueryStmt viewStmt = (QueryStmt) parseStmt(createViewStmt.getInlineViewDef()).getTopLevelNode(); line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/22252/18/fe/src/test/java/org/apache/impala/common/FrontendFixture.java@377 PS18, Line 377: TestParsedStatement parsedStmt = new TestParsedStatement(stmt, ctx.getQueryCtx().client_request.query_options); line too long (115 > 90) http://gerrit.cloudera.org:8080/#/c/22252/18/fe/src/test/java/org/apache/impala/common/FrontendTestBase.java File fe/src/test/java/org/apache/impala/common/FrontendTestBase.java: http://gerrit.cloudera.org:8080/#/c/22252/18/fe/src/test/java/org/apache/impala/common/FrontendTestBase.java@85 PS18, Line 85: protected static final Logger LOG = LoggerFactory.getLogger(FrontendTestBase.class.getName()); line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/22252/18/fe/src/test/java/org/apache/impala/common/TestParsedStatement.java File fe/src/test/java/org/apache/impala/common/TestParsedStatement.java: http://gerrit.cloudera.org:8080/#/c/22252/18/fe/src/test/java/org/apache/impala/common/TestParsedStatement.java@55 PS18, Line 55: protected static final Logger LOG = LoggerFactory.getLogger(TestParsedStatement.class.getName()); line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/22252/18/fe/src/test/java/org/apache/impala/common/TestParsedStatement.java@72 PS18, Line 72: stmt_ = Parser.parse(stmtSql); line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22252/18/fe/src/test/java/org/apache/impala/common/TestParsedStatement.java@80 PS18, Line 80: @Override line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22252/18/java/external-frontend/src/main/java/org/apache/impala/external/TestJniFrontend.java File java/external-frontend/src/main/java/org/apache/impala/external/TestJniFrontend.java: http://gerrit.cloudera.org:8080/#/c/22252/18/java/external-frontend/src/main/java/org/apache/impala/external/TestJniFrontend.java@88 PS18, Line 88: public TestTransactionContextBuilder(BackendConfig backendConfig) throws ImpalaException { line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/22252/18/java/test-frontend/src/main/java/org/apache/impala/service/BETestJniFrontend.java File java/test-frontend/src/main/java/org/apache/impala/service/BETestJniFrontend.java: http://gerrit.cloudera.org:8080/#/c/22252/18/java/test-frontend/src/main/java/org/apache/impala/service/BETestJniFrontend.java@257 PS18, Line 257: public TestTransactionContextBuilder(BackendConfig backendConfig) throws ImpalaException { line too long (94 > 90) -- To view, visit http://gerrit.cloudera.org:8080/22252 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idb8b54b8a2c36740bc6a10e8fec64dc70541327c Gerrit-Change-Number: 22252 Gerrit-PatchSet: 18 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Sun, 29 Dec 2024 22:12:01 +0000 Gerrit-HasComments: Yes
