Xuebin Su has posted comments on this change. ( http://gerrit.cloudera.org:8080/22014 )
Change subject: IMPALA-13154: Update metrics when loading an HDFS table ...................................................................... Patch Set 23: (3 comments) > Patch Set 22: > > (3 comments) > > Looks nice, thanks! Thanks for reviewing! http://gerrit.cloudera.org:8080/#/c/22014/22/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: http://gerrit.cloudera.org:8080/#/c/22014/22/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@390 PS22, Line 390: e the statistics of th > nit: this name and signature is a bit misleading, since we do not actually Thanks! Changed to "accumulate". Is that OK? http://gerrit.cloudera.org:8080/#/c/22014/22/fe/src/main/java/org/apache/impala/catalog/IcebergFileMetadataLoader.java File fe/src/main/java/org/apache/impala/catalog/IcebergFileMetadataLoader.java: http://gerrit.cloudera.org:8080/#/c/22014/22/fe/src/main/java/org/apache/impala/catalog/IcebergFileMetadataLoader.java@151 PS22, Line 151: fileMetadataStats_.accumulate(fd); : ++loadStats_.loadedFiles; > My suggestion earlier was to merge LoadStats and FileMetadataStats since th Thanks! We load file metadata not only from the file system, but also from the Thrift objects (in HdfsPartition.Builder.fromThrift() ). But LoadStats is not available in the latter case. http://gerrit.cloudera.org:8080/#/c/22014/22/fe/src/main/java/org/apache/impala/catalog/IcebergFileMetadataLoader.java@201 PS22, Line 201: fd); > nit: fd can't be null in this branch Thanks! Removed the check. -- To view, visit http://gerrit.cloudera.org:8080/22014 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6e2eb503b0f61b1e6403058bc5dc78d721e7e940 Gerrit-Change-Number: 22014 Gerrit-PatchSet: 23 Gerrit-Owner: Xuebin Su <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 30 Dec 2024 01:52:18 +0000 Gerrit-HasComments: Yes
