Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/22264 )
Change subject: IMPALA-13305: Better thrift compatibility checks based on pyparsing ...................................................................... Patch Set 7: (1 comment) Verified in https://jenkins.impala.io/job/gerrit-auto-critic-test/6/ http://gerrit.cloudera.org:8080/#/c/22264/3/bin/jenkins/critique-gerrit-review.py File bin/jenkins/critique-gerrit-review.py: http://gerrit.cloudera.org:8080/#/c/22264/3/bin/jenkins/critique-gerrit-review.py@53 PS3, Line 53: PYPARSING_VERSION = "3.1.4" > Changed to 3.1.4 since somehow the env in Jenkins can't install this versio In order to run the new test added in tests/infra, I changed the version in infra/python/deps/requirements.txt to 2.4.7 which is the highest version that can be installed in both python2 and python3. pyparsing-2.0.3 doesn't have pyparsing_common so the test will fail. -- To view, visit http://gerrit.cloudera.org:8080/22264 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia1dc4112404d0e7c5df94ee9f59a4fe2084b360d Gerrit-Change-Number: 22264 Gerrit-PatchSet: 7 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Tue, 31 Dec 2024 08:58:14 +0000 Gerrit-HasComments: Yes
