Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22231 )
Change subject: IMPALA-13620: Refresh compute_table_stats.py script ...................................................................... Patch Set 9: (4 comments) http://gerrit.cloudera.org:8080/#/c/22231/8/testdata/bin/compute-table-stats.sh File testdata/bin/compute-table-stats.sh: http://gerrit.cloudera.org:8080/#/c/22231/8/testdata/bin/compute-table-stats.sh@58 PS8, Line 58: # *_sales and *_returns have over 1000 partitions each. > Nit: this list of table names is repeated, could be moved into a variable t Done http://gerrit.cloudera.org:8080/#/c/22231/8/testdata/bin/compute-table-stats.sh@63 PS8, Line 63: > Nit: At first glance, I missed that the table names are now in the exclude Done http://gerrit.cloudera.org:8080/#/c/22231/8/testdata/bin/compute-table-stats.sh@92 PS8, Line 92: ${COMPUTE_STATS_SCRIPT} --db_names=functional \ > Nit: Consider matching the previous patterns where the second compute stat This is intentional. functional db has 107 tables, but only few of them used in PlannerTests and need COMPUTE STATS. http://gerrit.cloudera.org:8080/#/c/22231/8/tests/util/compute_table_stats.py File tests/util/compute_table_stats.py: http://gerrit.cloudera.org:8080/#/c/22231/8/tests/util/compute_table_stats.py@34 PS8, Line 34: LOG = logging.getLogger(__name__) > My dev machine has 16 CPUs. If it's critical to match the degree of parall Lower DEFAULT_PARALLELISM should be fine, maybe just slightly slower. Changed this to use IMPALA_BUILD_THREADS instead. -- To view, visit http://gerrit.cloudera.org:8080/22231 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1ebf02f95b957e7dda3a30622b87e8fca3197699 Gerrit-Change-Number: 22231 Gerrit-PatchSet: 9 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Tue, 31 Dec 2024 21:12:30 +0000 Gerrit-HasComments: Yes
