Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22288 )
Change subject: IMPALA-12785: Add commands to control event-processor status ...................................................................... Patch Set 1: (5 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/22288/1/be/src/catalog/catalog-server.cc File be/src/catalog/catalog-server.cc: http://gerrit.cloudera.org:8080/#/c/22288/1/be/src/catalog/catalog-server.cc@459 PS1, Line 459: VLOG_RPC << "SetEventProcessorStatus(): request=" << ThriftDebugString(req); Please make sure you don't output sensitive data with ThriftDebugString(). If so, use impala::RedactedDebugString() instead. http://gerrit.cloudera.org:8080/#/c/22288/1/be/src/catalog/catalog-server.cc@465 PS1, Line 465: VLOG_RPC << "SetEventProcessorStatus(): response=" << ThriftDebugStringNoThrow(resp); Please make sure you don't output sensitive data with ThriftDebugString(). If so, use impala::RedactedDebugString() instead. http://gerrit.cloudera.org:8080/#/c/22288/1/common/thrift/CatalogService.thrift File common/thrift/CatalogService.thrift: PS1: This file is used in communication between impalad and catalogd/statestore. Please make sure impalads can still work with new/old versions of catalogd and statestore. Basically only new optional fields can be added. http://gerrit.cloudera.org:8080/#/c/22288/1/common/thrift/CatalogService.thrift@758 PS1, Line 758: 1: required string action Modifying/adding this required field might break the compatibility between impalad and catalogd/statestore during upgrade http://gerrit.cloudera.org:8080/#/c/22288/1/common/thrift/CatalogService.thrift@763 PS1, Line 763: 1: required CatalogServiceVersion protocol_version = CatalogServiceVersion.V2 Modifying/adding this required field might break the compatibility between impalad and catalogd/statestore during upgrade -- To view, visit http://gerrit.cloudera.org:8080/22288 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iacafc9d33746709ed1108bd03042dd9b1625920c Gerrit-Change-Number: 22288 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Thu, 02 Jan 2025 08:34:17 +0000 Gerrit-HasComments: Yes
