Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22294 )
Change subject: IMPALA-13637: Add flag skip_tuple_analysis_in_aggregate ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/22294/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22294/1//COMMIT_MSG@7 PS1, Line 7: flag > The change looks good, just not sure which would be better, a query option For this case, I prefer flag because I consider this as a must have feature (skip_tuple_analysis_in_aggregate=false). But if it is bad for any query, it is best to disable totally and stay at old behavior until corrective action is taken (ie., collecting stats, rewrite tables, further code improvement, etc). -- To view, visit http://gerrit.cloudera.org:8080/22294 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iabd8daa3d9414fc33d232643014042dc20530514 Gerrit-Change-Number: 22294 Gerrit-PatchSet: 1 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Fri, 03 Jan 2025 19:00:43 +0000 Gerrit-HasComments: Yes
