Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/22295 )
Change subject: IMPALA-13638: Translate apostrophe to underscore in Prometheus metric names. ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/22295/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22295/1//COMMIT_MSG@17 PS1, Line 17: https://prometheus.io/docs/concepts/data_model/#metric-names-and-labels > Should we follow the described name pattern strictly? I mean we can match a I don't know! I'm inclined to keep the fix focused on what was broken. Hopefully the changes to the python test will catch any other weirdness that creeps in. What do you think? http://gerrit.cloudera.org:8080/#/c/22295/1//COMMIT_MSG@22 PS1, Line 22: TESTING: > Could you please add tests to metrics-test.cpp as well? Thanks, done -- To view, visit http://gerrit.cloudera.org:8080/22295 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I557b123c075dff0b14ac527de08bc6177bd2a3f6 Gerrit-Change-Number: 22295 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Sherman <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Fri, 03 Jan 2025 23:52:08 +0000 Gerrit-HasComments: Yes
