Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21728 )
Change subject: IMPALA-13288: OAuth AuthN Support for Impala ...................................................................... Patch Set 24: (2 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/21728/24/be/src/util/oauth-util.cc File be/src/util/oauth-util.cc: http://gerrit.cloudera.org:8080/#/c/21728/24/be/src/util/oauth-util.cc@708 PS24, Line 708: void OAuthSnapshot::AddRSAPublicKey(const std::string &key_id, OAuthPublicKey* jwk_pub_key) { line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/21728/24/be/src/util/oauth-util.cc@716 PS24, Line 716: void OAuthSnapshot::AddECPublicKey(const std::string &key_id, OAuthPublicKey* jwk_pub_key) { line too long (92 > 90) -- To view, visit http://gerrit.cloudera.org:8080/21728 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I65dc8db917476b0f0d29b659b9fa51ebaf45b7a6 Gerrit-Change-Number: 21728 Gerrit-PatchSet: 24 Gerrit-Owner: gaurav singh <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Comment-Date: Mon, 06 Jan 2025 18:10:18 +0000 Gerrit-HasComments: Yes
