Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22032 )
Change subject: IMPALA-13086: Lower AggregationNode estimate using stats predicate ...................................................................... Patch Set 14: (2 comments) http://gerrit.cloudera.org:8080/#/c/22032/13/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java File fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java: http://gerrit.cloudera.org:8080/#/c/22032/13/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@2765 PS13, Line 2765: originalSize == exprs.size() > nit: if 'originalSize == exprs.size()' we could just return ndvMult (which That should work. Will do it in next patch set. http://gerrit.cloudera.org:8080/#/c/22032/13/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java File fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java: http://gerrit.cloudera.org:8080/#/c/22032/13/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java@235 PS13, Line 235: // One of joinNode's ScanNode child is already associated with tblRef_.getId(). : // Unset previous mapping so that unionNode will be acknowledged as the first : // producer node. : analyzer_.unsetProducingNode(tblRef_.getId()); > Would it also work if we created a new Tuple only for the UnionNode based o Yes, it will work if this UnionNode has different TupleId than any ScanNode under it. -- To view, visit http://gerrit.cloudera.org:8080/22032 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia840d68f1c4f126d4e928461ec5c44545dbf25f8 Gerrit-Change-Number: 22032 Gerrit-PatchSet: 14 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 06 Jan 2025 19:02:17 +0000 Gerrit-HasComments: Yes
