Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21930 )
Change subject: IMPALA-12648: Add KILL QUERY statement ...................................................................... Patch Set 27: (2 comments) http://gerrit.cloudera.org:8080/#/c/21930/24/be/src/service/impala-server.h File be/src/service/impala-server.h: http://gerrit.cloudera.org:8080/#/c/21930/24/be/src/service/impala-server.h@858 PS24, Line 858: /// be recorded in the INFO log. > Thanks! Changed. Ack http://gerrit.cloudera.org:8080/#/c/21930/24/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/21930/24/be/src/service/impala-server.cc@1795 PS24, Line 1795: << ", method=" << (from_kill_query_statement ? "kill_query" : "cancel_rpc"); > Thanks! Added LOG both here and in ImpalaServer::KillQuery() I meant passing an argument to Cancel() that just changes the logging. I think with logging KillQuery() below, we don't need the additional method= detail. -- To view, visit http://gerrit.cloudera.org:8080/21930 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If12d6e47b256b034ec444f17c7890aa3b40481c0 Gerrit-Change-Number: 21930 Gerrit-PatchSet: 27 Gerrit-Owner: Xuebin Su <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Comment-Date: Mon, 06 Jan 2025 19:52:14 +0000 Gerrit-HasComments: Yes
