Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22080 )
Change subject: IMPALA-12141: EP shouldn't fail while releasing write lock if the lock is not held previously ...................................................................... IMPALA-12141: EP shouldn't fail while releasing write lock if the lock is not held previously Without IMPALA-12832, Event Processor (EP) is going into error state when there is an issue while obtaining a table write lock because the finally-clause of releaseWriteLock() is always invoked even if the lock is not held by current thread. This patch addresses the problem by checking if the table holds write lock before releasing it. Note: With IMPALA-12832, the EP invalidates the table when an error is encountered which is still an overhead. With this patch EP will neither goes into error state nor invalidates when this issue is encountered. Testing: - Added an end-to-end to verify the same. Change-Id: Ib2e4c965796dd515ab8549efa616f72510ca447f Reviewed-on: http://gerrit.cloudera.org:8080/22080 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java M fe/src/main/java/org/apache/impala/util/DebugUtils.java M tests/custom_cluster/test_events_custom_configs.py 3 files changed, 50 insertions(+), 5 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/22080 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ib2e4c965796dd515ab8549efa616f72510ca447f Gerrit-Change-Number: 22080 Gerrit-PatchSet: 5 Gerrit-Owner: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]>
