Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10245 )
Change subject: IMPALA-6953: part 1: clean up DiskIoMgr ...................................................................... Patch Set 7: (3 comments) http://gerrit.cloudera.org:8080/#/c/10245/8//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10245/8//COMMIT_MSG@12 PS8, Line 12: Make DiskQueue is now an encapsulated class. > Nit: grammar Done http://gerrit.cloudera.org:8080/#/c/10245/8/be/src/runtime/io/disk-io-mgr.h File be/src/runtime/io/disk-io-mgr.h: http://gerrit.cloudera.org:8080/#/c/10245/8/be/src/runtime/io/disk-io-mgr.h@440 PS8, Line 440: /// Total bytes read by the IoMgr. Upon further examination, total_bytes_read_counter and read_timer appear to be unused, so I removed them. http://gerrit.cloudera.org:8080/#/c/10245/7/be/src/runtime/io/request-context.h File be/src/runtime/io/request-context.h: http://gerrit.cloudera.org:8080/#/c/10245/7/be/src/runtime/io/request-context.h@498 PS7, Line 498: inline void RequestContext::IncrementDiskThreadAfterDequeue(int disk_id) { > I meant could we even more the class definition to the .cc file? But it loo Ah, yeah that's a good idea, I fixed up those places where DiskIoMgr touched disk_states_. In the process of looking at this I realised that the "protected friend" thing I was doing didn't actually do what I expected, so I went away from that and just documented int. I separated that out into a follow-on patch to make it easier to review. I think I'll squash the two before merging to reduce code churn in the git history, if that works for you. -- To view, visit http://gerrit.cloudera.org:8080/10245 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5a6e393f8c01d10143cbac91108af37f6498c1b1 Gerrit-Change-Number: 10245 Gerrit-PatchSet: 7 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 22 May 2018 23:27:01 +0000 Gerrit-HasComments: Yes
