Michael Smith has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22285 )

Change subject: IMPALA-12993: Encrypt password in JDBC table properties when 
saving into HMS DB
......................................................................


Patch Set 7:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/22285/3/fe/src/main/java/org/apache/impala/catalog/DataSourceTable.java
File fe/src/main/java/org/apache/impala/catalog/DataSourceTable.java:

http://gerrit.cloudera.org:8080/#/c/22285/3/fe/src/main/java/org/apache/impala/catalog/DataSourceTable.java@69
PS3, Line 69:     keyGen.init(256);
> The password was masked in the output of 'desc formatted' and 'show create
I'm not really clear on the purpose of this patch then. It moves from plaintext 
password to encrypted password right next to plaintext encryption key.



--
To view, visit http://gerrit.cloudera.org:8080/22285
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4189f4d83377f3c780f6c246f78eb46b46af9305
Gerrit-Change-Number: 22285
Gerrit-PatchSet: 7
Gerrit-Owner: Pranav Lodha <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Pranav Lodha <[email protected]>
Gerrit-Reviewer: Wenzhe Zhou <[email protected]>
Gerrit-Comment-Date: Fri, 10 Jan 2025 00:19:09 +0000
Gerrit-HasComments: Yes

Reply via email to