Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21663 )
Change subject: IMPALA-13126: Obtain table read lock in EP to process partitioned event ...................................................................... Patch Set 10: Code-Review+2 (2 comments) LGTM. Carrying Csaba's +1. http://gerrit.cloudera.org:8080/#/c/21663/6/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java: http://gerrit.cloudera.org:8080/#/c/21663/6/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@1300 PS6, Line 1300: > Does the latest patchset address your concerns? Ack http://gerrit.cloudera.org:8080/#/c/21663/6/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@1811 PS6, Line 1811: if (isRename_) { : processRename(); : return; : } : : // Determine whether this is an event which we have already seen or if it is a new : // event : if (isSelfEvent()) { : infoLog("Not processing the event as it is a self-event"); : return; : } : // Ignore the event if this is a trivial event. See javadoc for : // canBeSkipped() for examples. : if (canBeSkipped()) { : metrics_.getCounter > Note that the table lock is only needed for partitioned events since > https://gerrit.cloudera.org/#/c/20516/ Ah, thanks for pointing out that! -- To view, visit http://gerrit.cloudera.org:8080/21663 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I26933f98556736f66df986f9440ebb64be395bc1 Gerrit-Change-Number: 21663 Gerrit-PatchSet: 10 Gerrit-Owner: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Fri, 10 Jan 2025 01:56:47 +0000 Gerrit-HasComments: Yes
