Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10479 )
Change subject: IMPALA-6953: part 2: clean up DiskIoMgr ...................................................................... Patch Set 1: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/10479/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10479/1//COMMIT_MSG@11 PS1, Line 11: merging. Both of these changes make sense on their own, so i don't see the need to squash. But I don't feel strongly so do what you feel is best/easiest in this case. http://gerrit.cloudera.org:8080/#/c/10479/1//COMMIT_MSG@15 PS1, Line 15: RequestContRequestContext whats that? -- To view, visit http://gerrit.cloudera.org:8080/10479 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie82849652266b6660dd479689e5134273b172eb5 Gerrit-Change-Number: 10479 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Comment-Date: Wed, 23 May 2018 00:19:23 +0000 Gerrit-HasComments: Yes
