Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21971 )
Change subject: IMPALA-13403: Refactor the checks of skip reloading file metadata for ALTER_TABLE events ...................................................................... IMPALA-13403: Refactor the checks of skip reloading file metadata for ALTER_TABLE events IMPALA-12487 adds an optimization that if an ALTER_TABLE event has trivial changes in StorageDescriptor (e.g. removing optional field 'storedAsSubDirectories'=false which defaults to false), file metadata reload will be skipped, no matter what changes are in the table properties. This is problematic since some HMS clients (e.g. Spark) could modify both the table properties and StorageDescriptor. If there is a non-trivial changes in table properties (e.g. 'location' change), we shouldn't skip reloading file metadata. Testing: - Added a unit test to verify the same Change-Id: Ia969dd32385ac5a1a9a65890a5ccc8cd257f4b97 Reviewed-on: http://gerrit.cloudera.org:8080/21971 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java M fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java 2 files changed, 19 insertions(+), 11 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/21971 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ia969dd32385ac5a1a9a65890a5ccc8cd257f4b97 Gerrit-Change-Number: 21971 Gerrit-PatchSet: 8 Gerrit-Owner: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]>
