Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21728 )
Change subject: WIP IMPALA-13288: OAuth AuthN Support for Impala ...................................................................... Patch Set 29: (6 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/21728/29/be/src/rpc/authentication.cc File be/src/rpc/authentication.cc: http://gerrit.cloudera.org:8080/#/c/21728/29/be/src/rpc/authentication.cc@815 PS29, Line 815: status = ExecEnv::GetInstance()->GetOAuthHelperInstance()->Verify(decoded_token.get()); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/21728/29/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/21728/29/be/src/service/impala-server.cc@3113 PS29, Line 3113: RETURN_IF_ERROR(ExecEnv::GetInstance()->GetJWTHelperInstance()->Init(FLAGS_jwks_file_path)); line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/21728/29/be/src/service/impala-server.cc@3116 PS29, Line 3116: RETURN_IF_ERROR(ExecEnv::GetInstance()->GetJWTHelperInstance()->Init(FLAGS_jwks_url, line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/21728/29/be/src/service/impala-server.cc@3128 PS29, Line 3128: RETURN_IF_ERROR(ExecEnv::GetInstance()->GetOAuthHelperInstance()->Init(FLAGS_oauth_file_path)); line too long (103 > 90) http://gerrit.cloudera.org:8080/#/c/21728/29/be/src/service/impala-server.cc@3131 PS29, Line 3131: RETURN_IF_ERROR(ExecEnv::GetInstance()->GetOAuthHelperInstance()->Init(FLAGS_oauth_url, line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/21728/29/be/src/util/webserver.cc File be/src/util/webserver.cc: http://gerrit.cloudera.org:8080/#/c/21728/29/be/src/util/webserver.cc@1118 PS29, Line 1118: status = ExecEnv::GetInstance()->GetOAuthHelperInstance()->Verify(decoded_token.get()); line too long (91 > 90) -- To view, visit http://gerrit.cloudera.org:8080/21728 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I65dc8db917476b0f0d29b659b9fa51ebaf45b7a6 Gerrit-Change-Number: 21728 Gerrit-PatchSet: 29 Gerrit-Owner: gaurav singh <gsi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: gaurav singh <gsi...@cloudera.com> Gerrit-Comment-Date: Fri, 10 Jan 2025 19:26:13 +0000 Gerrit-HasComments: Yes
