Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/22329 )
Change subject: IMPALA-12494: Clamp MEM_LIMIT_EXECUTORS and MEM_LIMIT_COORDINATORS ...................................................................... Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/22329/1/common/thrift/ImpalaInternalService.thrift File common/thrift/ImpalaInternalService.thrift: http://gerrit.cloudera.org:8080/#/c/22329/1/common/thrift/ImpalaInternalService.thrift@239 PS1, Line 239: 14: required i64 max_query_mem_limit_coordinators = 0; > Adding a required field 'max_query_mem_limit_coordinators' in TPoolConfig m TPoolConfig is based on static pool configurations (llama config) and primarily used in frontend and admission controller so shouldn't really break compatibility with catalogd/statestore during upgrade? http://gerrit.cloudera.org:8080/#/c/22329/1/common/thrift/ImpalaInternalService.thrift@244 PS1, Line 244: 15: required i64 min_query_mem_limit_coordinators = 0; > Adding a required field 'min_query_mem_limit_coordinators' in TPoolConfig m TPoolConfig is based on static pool configurations (llama config) and primarily used in frontend and admission controller so shouldn't really break compatibility with catalogd/statestore during upgrade? http://gerrit.cloudera.org:8080/#/c/22329/1/fe/src/main/java/org/apache/impala/util/RequestPoolService.java File fe/src/main/java/org/apache/impala/util/RequestPoolService.java: http://gerrit.cloudera.org:8080/#/c/22329/1/fe/src/main/java/org/apache/impala/util/RequestPoolService.java@403 PS1, Line 403: getPoolConfigValue( > line too long (93 > 90) Done http://gerrit.cloudera.org:8080/#/c/22329/1/fe/src/main/java/org/apache/impala/util/RequestPoolService.java@405 PS1, Line 405: result.setMin_query_mem_limit_coordinators( > line too long (93 > 90) Done http://gerrit.cloudera.org:8080/#/c/22329/1/tests/custom_cluster/test_admission_controller.py File tests/custom_cluster/test_admission_controller.py: http://gerrit.cloudera.org:8080/#/c/22329/1/tests/custom_cluster/test_admission_controller.py@730 PS1, Line 730: = > flake8: W504 line break after binary operator Done http://gerrit.cloudera.org:8080/#/c/22329/1/tests/custom_cluster/test_admission_controller.py@733 PS1, Line 733: = > flake8: W504 line break after binary operator Done -- To view, visit http://gerrit.cloudera.org:8080/22329 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I262910284cbf84b8ba7e0c949bbf053dbfe44a0d Gerrit-Change-Number: 22329 Gerrit-PatchSet: 2 Gerrit-Owner: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Fri, 10 Jan 2025 23:13:25 +0000 Gerrit-HasComments: Yes
