Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/21728 )
Change subject: WIP IMPALA-13288: OAuth AuthN Support for Impala ...................................................................... Patch Set 32: (6 comments) http://gerrit.cloudera.org:8080/#/c/21728/32//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21728/32//COMMIT_MSG@16 PS32, Line 16: What's differences between JWT auth and OAuth? Could both of them are enabled at same time? http://gerrit.cloudera.org:8080/#/c/21728/32//COMMIT_MSG@19 PS32, Line 19: access token. Please add new test cases for oauth? http://gerrit.cloudera.org:8080/#/c/21728/32/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/21728/32/be/src/service/impala-server.cc@3110 PS32, Line 3110: / return error if both FLAGS_jwt_token_auth and FLAGS_oauth_token_auth are set as true. http://gerrit.cloudera.org:8080/#/c/21728/32/be/src/service/impala-server.cc@3127 PS32, Line 3127: JWT OAuth http://gerrit.cloudera.org:8080/#/c/21728/32/be/src/transport/THttpServer.cpp File be/src/transport/THttpServer.cpp: http://gerrit.cloudera.org:8080/#/c/21728/32/be/src/transport/THttpServer.cpp@330 PS32, Line 330: (has_jwt_ Here we assume jwt and oauth can not be enabled simultaneously. Please mention in commit message. http://gerrit.cloudera.org:8080/#/c/21728/32/shell/impala_client.py File shell/impala_client.py: http://gerrit.cloudera.org:8080/#/c/21728/32/shell/impala_client.py@a1169 PS32, Line 1169: unnecessary change -- To view, visit http://gerrit.cloudera.org:8080/21728 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I65dc8db917476b0f0d29b659b9fa51ebaf45b7a6 Gerrit-Change-Number: 21728 Gerrit-PatchSet: 32 Gerrit-Owner: gaurav singh <gsi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Reviewer: gaurav singh <gsi...@cloudera.com> Gerrit-Comment-Date: Sun, 12 Jan 2025 05:13:41 +0000 Gerrit-HasComments: Yes
