Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/22173 )
Change subject: IMPALA-13149: Show JVM info in the WebUI ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/22173/5/be/src/util/default-path-handlers.cc File be/src/util/default-path-handlers.cc: http://gerrit.cloudera.org:8080/#/c/22173/5/be/src/util/default-path-handlers.cc@290 PS5, Line 290: if (!RunShellProcess(cmd, &msg, false, {"JAVA_TOOL_OPTIONS"})) { > I'm a bit concerned on these: Here is a way to launch impalad without setting JAVA_HOME: Launch the minicluster and use "killall impalad" to kill all impalad processes. Open a new terminal and go into the IMPALA_HOME folder. Don't source bin/impala-config.sh. Set the env vars manually: export IMPALA_HOME=/home/quanlong/workspace/Impala export CLASSPATH="${IMPALA_HOME}/fe/target/dependency/*:${IMPALA_HOME}/fe/src/test/resources:${IMPALA_HOME}/fe/target/*" export LD_LIBRARY_PATH="$IMPALA_HOME/toolchain/toolchain-packages-gcc10.4.0/gcc-10.4.0/lib64:$IMPALA_HOME/toolchain/toolchain-packages-gcc10.4.0/kudu-e742f86f6d/debug/lib:$IMPALA_HOME/toolchain/toolchain-packages-gcc10.4.0/kudu-e742f86f6d/debug/lib64:$IMPALA_HOME/toolchain/toolchain-packages-gcc10.4.0/gcc-10.4.0/lib64:/home/quanlong/software/jdk-11.0.25/lib/server/" export LIBHDFS_OPTS=" -Djava.library.path=/home/quanlong/workspace/Impala/toolchain/cdp_components-58457853/hadoop-3.1.1.7.3.1.0-160/lib/native/ -XX:ErrorFile=/home/quanlong/workspace/Impala/logs/hs_err_pid%p.log -XX:MaxPermSize=128m" Launch impalad by $IMPALA_HOME/be/build/latest/service/impalad -v=1 -log_filename=impalad -log_dir=$IMPALA_HOME/logs/cluster Note that I add JDK11 in LD_LIBRARY_PATH so impalad is actually using JDK11. However, the default "java" in my OS is java8. So the WebUI is showing the version of Java8 which is wrong. A possible way to fix this is using something like JniUtil::GetJNIEnv()->GetVersion(). This returns an int. Maybe we can construct the java version string using info like this. -- To view, visit http://gerrit.cloudera.org:8080/22173 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iee03a05af9f0c5c2a7ab108ade503c6131bfe414 Gerrit-Change-Number: 22173 Gerrit-PatchSet: 5 Gerrit-Owner: Saurabh Katiyal <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Tue, 14 Jan 2025 09:36:07 +0000 Gerrit-HasComments: Yes
