Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/21728 )
Change subject: IMPALA-13288: OAuth AuthN Support for Impala ...................................................................... Patch Set 48: Code-Review+1 (4 comments) http://gerrit.cloudera.org:8080/#/c/21728/39//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21728/39//COMMIT_MSG@16 PS39, Line 16: Else only one of jwt or oauth is supported. > This has been a pre existing change for jwt. So OAuth will have the same po Done http://gerrit.cloudera.org:8080/#/c/21728/39/be/src/rpc/authentication.cc File be/src/rpc/authentication.cc: http://gerrit.cloudera.org:8080/#/c/21728/39/be/src/rpc/authentication.cc@1679 PS39, Line 1679: } > No need to declare this variable. Just use FLAGS_oauth_token_auth directly Done http://gerrit.cloudera.org:8080/#/c/21728/39/be/src/runtime/exec-env.h File be/src/runtime/exec-env.h: http://gerrit.cloudera.org:8080/#/c/21728/39/be/src/runtime/exec-env.h@33 PS39, Line 33: #include "util/jwt-util-internal.h" > Removing this breaks the build Oh, I see now that jwt-util.h is missing an import of jwt-util-internal.h. Fixing that issue is beyond the scope of this change. http://gerrit.cloudera.org:8080/#/c/21728/39/be/src/runtime/exec-env.cc File be/src/runtime/exec-env.cc: http://gerrit.cloudera.org:8080/#/c/21728/39/be/src/runtime/exec-env.cc@63 PS39, Line 63: #include "util/jwt-util-internal.h" > Removing this breaks the build Oh, I see now that jwt-util.h is missing an import of jwt-util-internal.h. Fixing that issue is beyond the scope of this change. -- To view, visit http://gerrit.cloudera.org:8080/21728 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I65dc8db917476b0f0d29b659b9fa51ebaf45b7a6 Gerrit-Change-Number: 21728 Gerrit-PatchSet: 48 Gerrit-Owner: gaurav singh <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: gaurav singh <[email protected]> Gerrit-Comment-Date: Tue, 14 Jan 2025 21:34:25 +0000 Gerrit-HasComments: Yes
