Impala Public Jenkins has submitted this change and it was merged. (
http://gerrit.cloudera.org:8080/22286 )
Change subject: IMPALA-13634: ImpalaTestSuite.cleanup_db() should use its own
client
......................................................................
IMPALA-13634: ImpalaTestSuite.cleanup_db() should use its own client
ImpalaTestSuite.cleanup_db(cls, db_name, sync_ddl=1) is used to drop the
entire db. Currently it uses cls.client and sets sync_ddl based on the
parameter. This clears all the query options of cls.client and makes it
always run with the same sync_ddl value unless the test code explicitly
set query options again.
This patch changes cleanup_db() to use a dedicated client. Tested with
some tests that uses this method and see performance improvement:
TestName
Before After
metadata/test_explain.py::TestExplainEmptyPartition
52s 9s
query_test/test_insert_behaviour.py::TestInsertBehaviour::test_insert_select_with_empty_resultset
62s 15s
metadata/test_metadata_query_statements.py::TestMetadataQueryStatements::test_describe_db
(exhaustive) 160s 25s
Change-Id: Icb01665bc18d24e2fce4383df87c4607cf4562f1
Reviewed-on: http://gerrit.cloudera.org:8080/22286
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
---
M tests/common/impala_test_suite.py
M tests/metadata/test_compute_stats.py
M tests/metadata/test_metadata_query_statements.py
3 files changed, 15 insertions(+), 11 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/22286
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Icb01665bc18d24e2fce4383df87c4607cf4562f1
Gerrit-Change-Number: 22286
Gerrit-PatchSet: 5
Gerrit-Owner: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Daniel Becker <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
