Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/22355 )
Change subject: Add aws-sdk-cpp (bedrock) libraries ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/22355/2/source/aws-sdk-cpp/build.sh File source/aws-sdk-cpp/build.sh: http://gerrit.cloudera.org:8080/#/c/22355/2/source/aws-sdk-cpp/build.sh@2 PS2, Line 2: 2024 nit. do we need to update the year to 2025? http://gerrit.cloudera.org:8080/#/c/22355/2/source/aws-sdk-cpp/build.sh@32 PS2, Line 32: ./prefetch_crt_dependency.sh Seems wrap is for logging stuff, do we also need it to run this shell? "wrap ./prefetch_crt_dependency.sh" -- To view, visit http://gerrit.cloudera.org:8080/22355 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8c428195e8be24de53b2b30479a4966e43db74cd Gerrit-Change-Number: 22355 Gerrit-PatchSet: 2 Gerrit-Owner: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Thu, 16 Jan 2025 02:06:27 +0000 Gerrit-HasComments: Yes
