Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/22358
Change subject: IMPALA-13672: Migrate query_test/test_kudu.py to use hs2 protocol ...................................................................... IMPALA-13672: Migrate query_test/test_kudu.py to use hs2 protocol This patch migrate query_test/test_kudu.py to use hs2 client protocol as much as possible. Here are the steps taken: - Remove usage of deprecated cursor and unique_cursor fixture. - Replace most of direct ImpalaTestSuite.cient usage with helper function call such as execute_query(). - Remove all "SET" query invocation and replace it with passing exec_option dictionary to helper method. - Replace veryfing kudu modified / inserted rows from reading query output to reading runtime profile counters. - Add HS2_TYPES section at test cases where only TYPES exist. KuduTestSuite is fixed with hs2 protocol dimension. Meanwhile, CustomKuduTest is fixed to use beeswax protocol dimension until proper migration can be done. After this patch, all test_kudu.py tests that accept 'vector' fixture will effectively use hs2 protocol. Test that don't accept 'vector' will continue to use ImpalaTestSuite.cient that is a beeswax client. However, all tests are compatible with hs2 and will continue working if ImpalaTestSuite.cient switch into an hs2 client. Catched a bug where "SHOW PARTITIONS" via hs2 over kudu table will shows NULL number of #Replicas because TResultRowBuilder does not have overload for int type value. Testing: - Run and pass all tests extended from KuduTestSuite in exhaustive mode. - Repeat the same test above with ImpalaTestSuite.cient manually switched into an hs2 client. IMPALA-13668 should provide a better way tochange it through py.test config. Change-Id: I5f38baf5a0bbde1a1ad0bb4666c300f4f3cabd33 --- M fe/src/main/java/org/apache/impala/catalog/FeKuduTable.java M fe/src/main/java/org/apache/impala/util/TResultRowBuilder.java M testdata/workloads/functional-query/queries/QueryTest/kudu-scan-node.test M testdata/workloads/functional-query/queries/QueryTest/kudu_create_table_like_table.test M testdata/workloads/functional-query/queries/QueryTest/kudu_delete.test M testdata/workloads/functional-query/queries/QueryTest/kudu_insert.test M testdata/workloads/functional-query/queries/QueryTest/kudu_update.test M testdata/workloads/functional-query/queries/QueryTest/kudu_upsert.test M tests/common/impala_connection.py M tests/common/impala_test_suite.py M tests/common/kudu_test_suite.py M tests/common/test_result_verifier.py M tests/custom_cluster/test_kudu.py M tests/query_test/test_kudu.py 14 files changed, 709 insertions(+), 504 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/58/22358/1 -- To view, visit http://gerrit.cloudera.org:8080/22358 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I5f38baf5a0bbde1a1ad0bb4666c300f4f3cabd33 Gerrit-Change-Number: 22358 Gerrit-PatchSet: 1 Gerrit-Owner: Riza Suminto <[email protected]>
