Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/21931 )
Change subject: IMPALA-13205: Do not include Iceberg position fields for MERGE statements with INSERT merge clauses ...................................................................... Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/21931/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21931/6//COMMIT_MSG@11 PS6, Line 11: listed in a MERGE statement. These fields can be omitted when there's no > If I understand it correctly, we can only leave these fields out if there's Done http://gerrit.cloudera.org:8080/#/c/21931/6//COMMIT_MSG@13 PS6, Line 13: has no existing delete files. > We should also include that we throw an exception if there are EQ-delete fi Done -- To view, visit http://gerrit.cloudera.org:8080/21931 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib62c78dab557625fa86988559b3732591755106f Gerrit-Change-Number: 21931 Gerrit-PatchSet: 7 Gerrit-Owner: Peter Rozsa <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 16 Jan 2025 15:28:43 +0000 Gerrit-HasComments: Yes
