Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21930 )
Change subject: IMPALA-12648: Add KILL QUERY statement ...................................................................... Patch Set 45: (4 comments) http://gerrit.cloudera.org:8080/#/c/21930/30/be/src/service/client-request-state.cc File be/src/service/client-request-state.cc: http://gerrit.cloudera.org:8080/#/c/21930/30/be/src/service/client-request-state.cc@2532 PS30, Line 2532: } > Thanks! Changed. Done http://gerrit.cloudera.org:8080/#/c/21930/45/fe/src/main/cup/sql-parser.cup File fe/src/main/cup/sql-parser.cup: http://gerrit.cloudera.org:8080/#/c/21930/45/fe/src/main/cup/sql-parser.cup@90 PS45, Line 90: private boolean isUnreservedKeyword(Integer tokenId) { Please add a comment that this should be kept in sync with 'ident_or_unreserved'. http://gerrit.cloudera.org:8080/#/c/21930/45/fe/src/main/cup/sql-parser.cup@342 PS45, Line 342: KW_PARTITIONS, KW_PRECEDING, KW_PREPARE_FN, KW_PRIMARY, KW_PRODUCED, KW_PURGE, KW_QUERY, nit: Is there a reason to rearrange this? Just clutters the review. http://gerrit.cloudera.org:8080/#/c/21930/45/fe/src/main/cup/sql-parser.cup@4621 PS45, Line 4621: | KW_KILL:r These are necessary to also allow "kill" and "query" to be used as identifiers? Since the lexer will presumably match them as KW_KILL and not an arbitrary string. -- To view, visit http://gerrit.cloudera.org:8080/21930 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If12d6e47b256b034ec444f17c7890aa3b40481c0 Gerrit-Change-Number: 21930 Gerrit-PatchSet: 45 Gerrit-Owner: Xuebin Su <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Comment-Date: Thu, 16 Jan 2025 22:16:08 +0000 Gerrit-HasComments: Yes
