Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/22216 )
Change subject: IMPALA-11265: Part3: Remove redundancy of file descriptors in coordinators ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/22216/5/fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java File fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java: http://gerrit.cloudera.org:8080/#/c/22216/5/fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java@a279 PS5, Line 279: I think it'd be still valuable to somehow test that the block location information is correct for Iceberg tables. My suggestion: * load the local Iceberg table, and retrieve the IcebergContentFileStore member * load the file descriptors via a file metadata loader (see FileMetadataLoaderTest). Alternatively we can just use an HDFS API * check that the block locations are the same for each file -- To view, visit http://gerrit.cloudera.org:8080/22216 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37c245d907baf1e46cb39d046c544bf50b37d581 Gerrit-Change-Number: 22216 Gerrit-PatchSet: 5 Gerrit-Owner: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 20 Jan 2025 14:21:51 +0000 Gerrit-HasComments: Yes
