Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21931 )
Change subject: IMPALA-13205: Do not include Iceberg position fields for MERGE statements with INSERT merge clauses ...................................................................... IMPALA-13205: Do not include Iceberg position fields for MERGE statements with INSERT merge clauses This patch makes the Iceberg position field inclusion conditional by including them only if there are UPDATE or DELETE merge clauses that are listed in a MERGE statement or the target table has existing delete files. These fields can be omitted when there's no delete file creation at the sink of the MERGE statement and the table has no existing delete files. Additionally, this change disables MERGE for Iceberg target tables that contain equality delete files, see IMPALA-13674. Tests: - iceberg-merge-insert-only planner test added Change-Id: Ib62c78dab557625fa86988559b3732591755106f Reviewed-on: http://gerrit.cloudera.org:8080/21931 Reviewed-by: Noemi Pap-Takacs <[email protected]> Reviewed-by: Daniel Becker <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M fe/src/main/java/org/apache/impala/analysis/IcebergMergeImpl.java M fe/src/test/java/org/apache/impala/analysis/AnalyzeModifyStmtsTest.java M fe/src/test/java/org/apache/impala/planner/PlannerTest.java A testdata/workloads/functional-planner/queries/PlannerTest/iceberg-merge-insert-only.test 4 files changed, 376 insertions(+), 7 deletions(-) Approvals: Noemi Pap-Takacs: Looks good to me, but someone else must approve Daniel Becker: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/21931 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ib62c78dab557625fa86988559b3732591755106f Gerrit-Change-Number: 21931 Gerrit-PatchSet: 12 Gerrit-Owner: Peter Rozsa <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
