Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/10486 )
Change subject: IMPALA-7060: Restrict Impala to only support timezones that work in Hive ...................................................................... Patch Set 1: (1 comment) Is this a breaking change? We normally hold on braking changes until we bump the major version. Is IMPALA-3307 going to go in on a minor release? Is it a breaking change? http://gerrit.cloudera.org:8080/#/c/10486/1/be/src/exprs/timezone_db.h File be/src/exprs/timezone_db.h: http://gerrit.cloudera.org:8080/#/c/10486/1/be/src/exprs/timezone_db.h@55 PS1, Line 55: map > Maybe use unordered_map instead ? Probably wouldn't make much of a differen const? -- To view, visit http://gerrit.cloudera.org:8080/10486 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I90859398081bae4976af31b09b3121c198b6adac Gerrit-Change-Number: 10486 Gerrit-PatchSet: 1 Gerrit-Owner: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Attila Jeges <atti...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-Comment-Date: Wed, 23 May 2018 18:30:02 +0000 Gerrit-HasComments: Yes