Riza Suminto has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22198 )

Change subject: IMPALA-13500: (Addendum) Do not assert CatalogD's partition id
......................................................................


Patch Set 3: Code-Review+2

(2 comments)

I tried loop the test 10 times and it pass.

http://gerrit.cloudera.org:8080/#/c/22198/1/tests/custom_cluster/test_events_custom_configs.py
File tests/custom_cluster/test_events_custom_configs.py:

http://gerrit.cloudera.org:8080/#/c/22198/1/tests/custom_cluster/test_events_custom_configs.py@1326
PS1, Line 1326:     log_regex = r"Invalidated objects in cache: \[partition 
{}:p={}"\
              :       .format(test
> I think this is clearer:
Done


http://gerrit.cloudera.org:8080/#/c/22198/2/tests/custom_cluster/test_events_custom_configs.py
File tests/custom_cluster/test_events_custom_configs.py:

http://gerrit.cloudera.org:8080/#/c/22198/2/tests/custom_cluster/test_events_custom_configs.py@1326
PS2, Line 1326:
> flake8: W605 invalid escape sequence '\['
Fix the code a bit to remove the warning in ps3.



--
To view, visit http://gerrit.cloudera.org:8080/22198
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I27cdeb2a4bed8afa30a27d05c7399c78af5bcebb
Gerrit-Change-Number: 22198
Gerrit-PatchSet: 3
Gerrit-Owner: Sai Hemanth Gantasala <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Comment-Date: Tue, 21 Jan 2025 01:31:16 +0000
Gerrit-HasComments: Yes

Reply via email to