Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22362 )
Change subject: IMPALA-13682: Implement missing capabilities in ImpylaHS2Client ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/22362/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22362/2//COMMIT_MSG@17 PS2, Line 17: Therefore, this patch breaks the assumption that an : ImpylaHS2Client is always under a single HS2 Session (see HIVE-11402 and : HIVE-14247 on why concurrent query with shared HS2 Session is : problematic). I can use some feedback on this. Either we allow multiple cursor/Session in single ImpylaHS2Client, or we refactor some tests to always create new ImpylaHS2Client class for concurrent queries. http://gerrit.cloudera.org:8080/#/c/22362/2/tests/common/impala_connection.py File tests/common/impala_connection.py: http://gerrit.cloudera.org:8080/#/c/22362/2/tests/common/impala_connection.py@153 PS2, Line 153: f > flake8: U100 Unused argument 'fetch_profile_after_close' These U100 warning are inevitable in this case and can be ignored. -- To view, visit http://gerrit.cloudera.org:8080/22362 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9ac07732424c16338e060c9392100b54337f11b8 Gerrit-Change-Number: 22362 Gerrit-PatchSet: 2 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Tue, 21 Jan 2025 06:15:51 +0000 Gerrit-HasComments: Yes
