Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22356 )
Change subject: IMPALA-LOTS3: clean version of commits squished for 2025 ...................................................................... Patch Set 7: (49 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/22356/7/bin/calcite_report_generator.py File bin/calcite_report_generator.py: http://gerrit.cloudera.org:8080/#/c/22356/7/bin/calcite_report_generator.py@105 PS7, Line 105: r flake8: E501 line too long (95 > 90 characters) http://gerrit.cloudera.org:8080/#/c/22356/7/fe/src/main/java/org/apache/impala/analysis/TupleIsNullPredicate.java File fe/src/main/java/org/apache/impala/analysis/TupleIsNullPredicate.java: http://gerrit.cloudera.org:8080/#/c/22356/7/fe/src/main/java/org/apache/impala/analysis/TupleIsNullPredicate.java@50 PS7, Line 50: protected static final Logger LOG = LoggerFactory.getLogger(TupleIsNullPredicate.class.getName()); line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/22356/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceOperandShuttle.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceOperandShuttle.java: http://gerrit.cloudera.org:8080/#/c/22356/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceOperandShuttle.java@146 PS7, Line 146: getCastedArgTypes(fn, castedOperandsCall.getOperands(), factory, rexBuilder, retType ); line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/22356/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceOperandShuttle.java@187 PS7, Line 187: if (!literal.isNull() && literal.getType().getSqlTypeName().equals(SqlTypeName.CHAR)) { line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/22356/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceOperandShuttle.java@247 PS7, Line 247: List<RelDataType> types = Lists.transform(rexCall.getOperands(), RexNode::getType); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/22356/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceOperandShuttle.java@331 PS7, Line 331: Type targetOperandType = isCaseFunction ? ImpalaTypeConverter.createImpalaType(retType) : fn.getArgs()[sigIndex]; line too long (119 > 90) http://gerrit.cloudera.org:8080/#/c/22356/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceOperandShuttle.java@477 PS7, Line 477: if (returnType.getSqlTypeName().equals(SqlTypeName.VARCHAR) && returnType.getPrecision() != Integer.MAX_VALUE) { line too long (118 > 90) http://gerrit.cloudera.org:8080/#/c/22356/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/functions/RexCallConverter.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/functions/RexCallConverter.java: http://gerrit.cloudera.org:8080/#/c/22356/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/functions/RexCallConverter.java@204 PS7, Line 204: : new AnalyzedCastExpr(impalaRetType, params.get(0), ((StringLiteral) params.get(1)).getStringValue()); line too long (111 > 90) http://gerrit.cloudera.org:8080/#/c/22356/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/functions/RexCallConverter.java@304 PS7, Line 304: : ImpalaTypeConverter.createImpalaType(fn.getReturnType(), rexCall.getType().getPrecision(), line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/22356/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/functions/RexCallConverter.java@307 PS7, Line 307: int precision = (rexCall.getOperator().getKind() == SqlKind.CASE && line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22356/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/functions/RexCallConverter.java@321 PS7, Line 321: return ImpalaTypeConverter.createImpalaType(fn.getReturnType(), rexCall.getType().getPrecision(), line too long (101 > 90) http://gerrit.cloudera.org:8080/#/c/22356/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaCastFunction.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaCastFunction.java: http://gerrit.cloudera.org:8080/#/c/22356/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaCastFunction.java@72 PS7, Line 72: rdt = factory.createTypeWithCharsetAndCollation(rdt, StandardCharsets.UTF_8, SqlCollation.IMPLICIT); line too long (106 > 90) http://gerrit.cloudera.org:8080/#/c/22356/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaConcatOrOperator.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaConcatOrOperator.java: http://gerrit.cloudera.org:8080/#/c/22356/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaConcatOrOperator.java@77 PS7, Line 77: private boolean isOrOperand(SqlOperatorBinding opBinding, RelDataType opType, int opNum) { line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/22356/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaNdvFunction.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaNdvFunction.java: http://gerrit.cloudera.org:8080/#/c/22356/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaNdvFunction.java@37 PS7, Line 37: protected static final Logger LOG = LoggerFactory.getLogger(ImpalaNdvFunction.class.getName()); line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/22356/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaAggRel.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaAggRel.java: http://gerrit.cloudera.org:8080/#/c/22356/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaAggRel.java@356 PS7, Line 356: Function fn = FunctionResolver.getExactFunction(aggFunction.getName(), aggFunction.getKind(), line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/22356/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaAnalyticRel.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaAnalyticRel.java: http://gerrit.cloudera.org:8080/#/c/22356/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaAnalyticRel.java@149 PS7, Line 149: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22356/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaAnalyticRel.java@217 PS7, Line 217: nullsFirst = true; line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22356/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaAnalyticRel.java@220 PS7, Line 220: nullsFirst = false; line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22356/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaHdfsScanRel.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaHdfsScanRel.java: http://gerrit.cloudera.org:8080/#/c/22356/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaHdfsScanRel.java@63 PS7, Line 63: protected static final Logger LOG = LoggerFactory.getLogger(ImpalaHdfsScanRel.class.getName()); line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/22356/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaHdfsScanRel.java@117 PS7, Line 117: if (SingleNodePlanner.addAcidSlotsIfNeeded(context.ctx_.getRootAnalyzer(), baseTblRef, impalaPartitions)) { line too long (111 > 90) http://gerrit.cloudera.org:8080/#/c/22356/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaHdfsScanRel.java@118 PS7, Line 118: physicalNode = SingleNodePlanner.createAcidJoinNode(context.ctx_.getRootAnalyzer(), baseTblRef, line too long (101 > 90) http://gerrit.cloudera.org:8080/#/c/22356/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaHdfsScanRel.java@141 PS7, Line 141: private List<Expr> createScanOutputExprs(List<SlotDescriptor> slotDescs) line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22356/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaHdfsScanRel.java@161 PS7, Line 161: Integer impalaPosition = calciteTable.getCalcitePosition(impalaColumn.getPosition()); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/22356/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaHdfsScanRel.java@206 PS7, Line 206: private boolean canUseCountStarOptimization(CalciteTable table, ParentPlanRelContext context, line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/22356/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaHdfsScanRel.java@208 PS7, Line 208: if (context.parentAggregate_ == null || !context.parentAggregate_.hasCountStarOnly()) { line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/22356/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ParentPlanRelContext.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ParentPlanRelContext.java: http://gerrit.cloudera.org:8080/#/c/22356/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ParentPlanRelContext.java@90 PS7, Line 90: ? planRelContext.parentAggregate_ line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22356/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/util/DummyAnalyzer.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/util/DummyAnalyzer.java: http://gerrit.cloudera.org:8080/#/c/22356/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/util/DummyAnalyzer.java@118 PS7, Line 118: public List<? extends FeDataSource> getDataSources(PatternMatcher createHivePatternMatcher) { line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/22356/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/util/DummyAnalyzer.java@144 PS7, Line 144: public TGetPartitionStatsResponse getPartitionStats(TableName table) throws InternalException { line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/22356/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/CombineValueNodesRule.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/CombineValueNodesRule.java: http://gerrit.cloudera.org:8080/#/c/22356/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/CombineValueNodesRule.java@60 PS7, Line 60: ImmutableList.Builder<ImmutableList<RexLiteral>> rowBuilder = new ImmutableList.Builder(); line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/22356/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/JoinProjectTransposeBtwRule.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/JoinProjectTransposeBtwRule.java: http://gerrit.cloudera.org:8080/#/c/22356/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/JoinProjectTransposeBtwRule.java@35 PS7, Line 35: * Planner rules based on {link@ org.apache.calcite.rel.rules.JoinProjectTransposeRule} specialized to Hive. line too long (108 > 90) http://gerrit.cloudera.org:8080/#/c/22356/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/JoinProjectTransposeBtwRule.java@68 PS7, Line 68: if (join.getJoinType().equals(JoinRelType.SEMI)) { line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22356/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/CalciteTable.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/CalciteTable.java: http://gerrit.cloudera.org:8080/#/c/22356/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/CalciteTable.java@86 PS7, Line 86: protected static final Logger LOG = LoggerFactory.getLogger(CalciteTable.class.getName()); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/22356/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteJniFrontend.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteJniFrontend.java: http://gerrit.cloudera.org:8080/#/c/22356/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteJniFrontend.java@83 PS7, Line 83: private static Pattern TABLE_NOT_FOUND = Pattern.compile(".*\\bTable '(.*)' not found\\b.*", line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/22356/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteJniFrontend.java@86 PS7, Line 86: private static Pattern COLUMN_NOT_FOUND = Pattern.compile(".*\\bColumn '(.*)' not found\\b.*", line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/22356/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteJniFrontend.java@243 PS7, Line 243: throw new UnsupportedFeatureException("Complex column " + m.group(1) + " not supported."); line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/22356/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteJniFrontend.java@249 PS7, Line 249: // LOG.info("SJC: COLUMN NOT FOUND EXCEPTION, COLUMN IS " + m.group(1) + " TABLE IS " + m.group(2)); line too long (105 > 90) http://gerrit.cloudera.org:8080/#/c/22356/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteJniFrontend.java@253 PS7, Line 253: throw new UnsupportedFeatureException("Complex column " + m.group(1) + " not supported."); line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/22356/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteMetadataHandler.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteMetadataHandler.java: http://gerrit.cloudera.org:8080/#/c/22356/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteMetadataHandler.java@105 PS7, Line 105: List<String> errorTables = populateCalciteSchema(reader_, queryCtx.getFrontend().getCatalog(), line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/22356/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteMetadataHandler.java@246 PS7, Line 246: List<String> errorTables, CalciteJniFrontend.QueryContext queryCtx) throws ImpalaException { line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/22356/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteOptimizer.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteOptimizer.java: http://gerrit.cloudera.org:8080/#/c/22356/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteOptimizer.java@98 PS7, Line 98: RelNode postOptimizedJoinPlan = runOptimizeNodesProgram(relBuilder, optimizedJoinPlan); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/22356/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteSingleNodePlanner.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteSingleNodePlanner.java: http://gerrit.cloudera.org:8080/#/c/22356/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteSingleNodePlanner.java@50 PS7, Line 50: protected static final Logger LOG = LoggerFactory.getLogger(CalciteSingleNodePlanner.class.getName()); line too long (104 > 90) http://gerrit.cloudera.org:8080/#/c/22356/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteSingleNodePlanner.java@55 PS7, Line 55: public CalciteSingleNodePlanner(PlannerContext ctx, CalciteAnalysisDriver analysisDriver) { line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/22356/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/type/ImpalaTypeConverter.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/type/ImpalaTypeConverter.java: http://gerrit.cloudera.org:8080/#/c/22356/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/type/ImpalaTypeConverter.java@89 PS7, Line 89: map.put(Type.CHAR, factory.createTypeWithCharsetAndCollation(charType, StandardCharsets.UTF_8, SqlCollation.IMPLICIT)); line too long (123 > 90) http://gerrit.cloudera.org:8080/#/c/22356/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/type/ImpalaTypeConverter.java@91 PS7, Line 91: map.put(Type.VARCHAR, factory.createTypeWithCharsetAndCollation(varcharType, StandardCharsets.UTF_8, SqlCollation.IMPLICIT)); line too long (129 > 90) http://gerrit.cloudera.org:8080/#/c/22356/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/type/ImpalaTypeConverter.java@92 PS7, Line 92: RelDataType stringType = factory.createSqlType(SqlTypeName.VARCHAR, Integer.MAX_VALUE); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/22356/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/type/ImpalaTypeConverter.java@93 PS7, Line 93: map.put(Type.STRING, factory.createTypeWithCharsetAndCollation(stringType, StandardCharsets.UTF_8, SqlCollation.IMPLICIT)); line too long (127 > 90) http://gerrit.cloudera.org:8080/#/c/22356/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/type/ImpalaTypeConverter.java@134 PS7, Line 134: varcharType = factory.createTypeWithCharsetAndCollation(varcharType, StandardCharsets.UTF_8, SqlCollation.IMPLICIT); line too long (124 > 90) http://gerrit.cloudera.org:8080/#/c/22356/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/type/ImpalaTypeConverter.java@139 PS7, Line 139: charType = factory.createTypeWithCharsetAndCollation(charType, StandardCharsets.UTF_8, SqlCollation.IMPLICIT); line too long (118 > 90) http://gerrit.cloudera.org:8080/#/c/22356/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/util/ParserUtil.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/util/ParserUtil.java: http://gerrit.cloudera.org:8080/#/c/22356/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/util/ParserUtil.java@44 PS7, Line 44: * <a href="https://www.postgresql.org/docs/14/sql-syntax-lexical.html#SQL-SYNTAX-CONSTANTS";> line too long (95 > 90) -- To view, visit http://gerrit.cloudera.org:8080/22356 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic300cf60551985d430cfda7e5403aea90f246150 Gerrit-Change-Number: 22356 Gerrit-PatchSet: 7 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Tue, 21 Jan 2025 22:30:46 +0000 Gerrit-HasComments: Yes
