Steve Carlin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22087 )
Change subject: IMPALA-13522: Calcite Planner: Treat the "real" type as double ...................................................................... IMPALA-13522: Calcite Planner: Treat the "real" type as double Real type was being treated as a float. E2E test can be found in exprs.test where there is a cast to real. Specifically, this test... select count(*) from alltypesagg where double_col >= 20.2 and cast(double_col as double) = cast(double_col as real) ... was casting double_col as a double and returning the wrong result previous to this commit. Change-Id: I5f3cc0e50a4dfc0e28f39d81b591c1b458fd59ce Reviewed-on: http://gerrit.cloudera.org:8080/22087 Reviewed-by: Joe McDonnell <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> Reviewed-by: Aman Sinha <[email protected]> --- M java/calcite-planner/src/main/java/org/apache/impala/calcite/type/ImpalaTypeConverter.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Joe McDonnell: Looks good to me, but someone else must approve Impala Public Jenkins: Verified Aman Sinha: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/22087 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I5f3cc0e50a4dfc0e28f39d81b591c1b458fd59ce Gerrit-Change-Number: 22087 Gerrit-PatchSet: 4 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]>
