Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22106 )
Change subject: IMPALA-13525: Handle escaped characters in string literal ...................................................................... Patch Set 3: (1 comment) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/22106/3/java/calcite-planner/src/main/java/org/apache/impala/calcite/util/ParserUtil.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/util/ParserUtil.java: http://gerrit.cloudera.org:8080/#/c/22106/3/java/calcite-planner/src/main/java/org/apache/impala/calcite/util/ParserUtil.java@44 PS3, Line 44: * <a href="https://www.postgresql.org/docs/14/sql-syntax-lexical.html#SQL-SYNTAX-CONSTANTS"> line too long (95 > 90) -- To view, visit http://gerrit.cloudera.org:8080/22106 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9b0fbe591d1101350b2ba0f6ddb2967b819ee685 Gerrit-Change-Number: 22106 Gerrit-PatchSet: 3 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Tue, 28 Jan 2025 01:45:58 +0000 Gerrit-HasComments: Yes
