Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22249 )
Change subject: IMPALA-13201: System Table Queries Execute When Admission Queues are Full ...................................................................... Patch Set 3: (3 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/22249/3/be/src/scheduling/admission-controller.cc File be/src/scheduling/admission-controller.cc: http://gerrit.cloudera.org:8080/#/c/22249/3/be/src/scheduling/admission-controller.cc@2258 PS3, Line 2258: executor_groups = GetExecutorGroupsForQuery(membership_snapshot->executor_groups, request); line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/22249/3/be/src/service/client-request-state.cc File be/src/service/client-request-state.cc: http://gerrit.cloudera.org:8080/#/c/22249/3/be/src/service/client-request-state.cc@2484 PS3, Line 2484: *ExecEnv::GetInstance()->cluster_membership_mgr()->GetSnapshot()->all_coordinators.get(); line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/22249/3/common/thrift/ImpalaInternalService.thrift File common/thrift/ImpalaInternalService.thrift: http://gerrit.cloudera.org:8080/#/c/22249/3/common/thrift/ImpalaInternalService.thrift@236 PS3, Line 236: 14: required bool only_coordinators Adding a required field 'only_coordinators' in TPoolConfig might break the compatibility between impalad and catalogd/statestore during upgrade -- To view, visit http://gerrit.cloudera.org:8080/22249 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5e0e64db92bdbf80f8b5bd85d001ffe4c8c9ffda Gerrit-Change-Number: 22249 Gerrit-PatchSet: 3 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Wed, 29 Jan 2025 00:43:10 +0000 Gerrit-HasComments: Yes
