Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/22419 )
Change subject: IMPALA-13705: Environment specific errors in test_encryption_exprs ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/22419/1/be/src/exprs/string-functions-ir.cc File be/src/exprs/string-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/22419/1/be/src/exprs/string-functions-ir.cc@262 PS1, Line 262: if (context->impl()->GetConstFnAttr(FunctionContextImpl::UTF8_MODE)) { Is this change intentional? http://gerrit.cloudera.org:8080/#/c/22419/1/testdata/workloads/functional-query/queries/QueryTest/encryption_exprs_aes_128_gcm.test File testdata/workloads/functional-query/queries/QueryTest/encryption_exprs_aes_128_gcm.test: http://gerrit.cloudera.org:8080/#/c/22419/1/testdata/workloads/functional-query/queries/QueryTest/encryption_exprs_aes_128_gcm.test@29 PS1, Line 29: ==== : ---- QUERY : select count(*) from functional.alltypes where string_col = aes_decrypt(aes_encrypt(string_col, '1234567890123456', : 'AES_128_GCM', '1234567890123456'), '1234567890123456', 'AES_128_GCM', '1234567890123456'); : ---- RESULTS : 7300 : ---- TYPES : BIGINT : ==== : ---- QUERY : select count(*) from functional_parquet.alltypes where CAST(timestamp_col AS STRING) = : aes_decrypt(aes_encrypt(CAST(timestamp_col AS STRING), '1234567890123456', 'AES_128_GCM', '1234567890123456'), : '1234567890123456', 'AES_128_GCM', '1234567890123456'); Only this file seems to contain tests with FROM clause, while this .test can be skipped. I would prefer to have such a test with a mode that is always tested (or probably have test like this for all modes) -- To view, visit http://gerrit.cloudera.org:8080/22419 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I27146cda4fa41965de35821315738e5502d1b018 Gerrit-Change-Number: 22419 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Comment-Date: Wed, 29 Jan 2025 16:40:56 +0000 Gerrit-HasComments: Yes
