Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22404 )
Change subject: IMPALA-13694: Add ImpalaTestSuite.__reset_impala_clients method ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/22404/3/tests/common/impala_connection.py File tests/common/impala_connection.py: http://gerrit.cloudera.org:8080/#/c/22404/3/tests/common/impala_connection.py@75 PS3, Line 75: if ',' in val: > Should we check if 'val' is already quoted? Done. Stripping first should achieve the same result. http://gerrit.cloudera.org:8080/#/c/22404/3/tests/common/impala_connection.py@239 PS3, Line 239: if self.__default_query_options is None: > This is not thread-safe. Do we know if some parallel e2e tests share the cl I think it is safe. I tried with test below: ./run-tests.py -k test_cache_cancellation query_test/test_hdfs_caching.py It started 2 parallel tests where each of them create a different beeswax session. But as a precaution, I change __collect_default_options to be idemptotent. http://gerrit.cloudera.org:8080/#/c/22404/3/tests/query_test/test_exprs.py File tests/query_test/test_exprs.py: http://gerrit.cloudera.org:8080/#/c/22404/3/tests/query_test/test_exprs.py@313 PS3, Line 313: def get_workload(cls): > Should we close this? You are right. Patch set 4 ensure we're closing it. -- To view, visit http://gerrit.cloudera.org:8080/22404 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieb47fec9f384cb58b19fdbd10ff7aa0850ad6277 Gerrit-Change-Number: 22404 Gerrit-PatchSet: 4 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Thu, 30 Jan 2025 17:46:49 +0000 Gerrit-HasComments: Yes
