Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/22422 )
Change subject: IMPALA-13703: Cancel running queries after shutdown deadline ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/22422/3/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/22422/3/be/src/service/impala-server.cc@335 PS3, Line 335: DEFINE_int64(shutdown_query_cancel_period_s, 60, We probably need to put this deadline within the shutdown deadline. Because many times there are external systems which impost a shutdown deadline and they are not aware of additional deadline for cancelling queries. For instance these external system invoke the shutdown script and typically pass a single deadline: https://github.com/apache/impala/blob/master/bin/graceful_shutdown_backends.sh So we should follow a single deadline and handle query cancellation within that deadline. -- To view, visit http://gerrit.cloudera.org:8080/22422 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1cac2e100d329644e21fdceb0b23901b08079130 Gerrit-Change-Number: 22422 Gerrit-PatchSet: 3 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Thu, 30 Jan 2025 22:51:07 +0000 Gerrit-HasComments: Yes
