Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/22086 )
Change subject: IMPALA-13523: Decimal Precision needs to be in return type ...................................................................... Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/22086/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/CommonOperatorFunctions.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/CommonOperatorFunctions.java: http://gerrit.cloudera.org:8080/#/c/22086/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/CommonOperatorFunctions.java@133 PS7, Line 133: getDecimalReturnType It looks like we don't use this anymore? http://gerrit.cloudera.org:8080/#/c/22086/7/testdata/workloads/functional-query/queries/QueryTest/exprs.test File testdata/workloads/functional-query/queries/QueryTest/exprs.test: http://gerrit.cloudera.org:8080/#/c/22086/7/testdata/workloads/functional-query/queries/QueryTest/exprs.test@3383 PS7, Line 3383: Nit: trailing space -- To view, visit http://gerrit.cloudera.org:8080/22086 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie10521b587a74930a01c08b711364f897bb2dc33 Gerrit-Change-Number: 22086 Gerrit-PatchSet: 7 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Fri, 31 Jan 2025 18:10:02 +0000 Gerrit-HasComments: Yes
