Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/22104 )
Change subject: IMPALA-13524: Calcite planner: support for functions in exprs.test ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/22104/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22104/3//COMMIT_MSG@12 PS3, Line 12: to nit: typo here ? 'to' should be removed http://gerrit.cloudera.org:8080/#/c/22104/3/java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaConvertletTable.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaConvertletTable.java: http://gerrit.cloudera.org:8080/#/c/22104/3/java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaConvertletTable.java@34 PS3, Line 34: /** : * : */ nit: remove the empty comments or you might want to add some comments about when a ConvertLet is used. I am not sure myself of when certain functions/operator need a convertlet instead of going through the normal function resolver). -- To view, visit http://gerrit.cloudera.org:8080/22104 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib8c5d5719a409a32ddb6946d1a87c77773f20820 Gerrit-Change-Number: 22104 Gerrit-PatchSet: 3 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Sun, 02 Feb 2025 02:07:20 +0000 Gerrit-HasComments: Yes
