Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22443 )

Change subject: IMPALA-13726 Add admission control slots to /queries page in 
webui
......................................................................


Patch Set 1:

(4 comments)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python3 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with Python3's venv installed.

http://gerrit.cloudera.org:8080/#/c/22443/1/tests/custom_cluster/test_workload_mgmt_init.py
File tests/custom_cluster/test_workload_mgmt_init.py:

http://gerrit.cloudera.org:8080/#/c/22443/1/tests/custom_cluster/test_workload_mgmt_init.py@185
PS1, Line 185: u
flake8: E501 line too long (95 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/22443/1/tests/custom_cluster/test_workload_mgmt_init.py@271
PS1, Line 271: ,
flake8: E231 missing whitespace after ','


http://gerrit.cloudera.org:8080/#/c/22443/1/tests/custom_cluster/test_workload_mgmt_init.py@284
PS1, Line 284: ,
flake8: E231 missing whitespace after ','


http://gerrit.cloudera.org:8080/#/c/22443/1/tests/util/workload_management.py
File tests/util/workload_management.py:

http://gerrit.cloudera.org:8080/#/c/22443/1/tests/util/workload_management.py@612
PS1, Line 612: )
flake8: E501 line too long (91 > 90 characters)



--
To view, visit http://gerrit.cloudera.org:8080/22443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I057493b7767902a417dfeb75cdaeffd452d66789
Gerrit-Change-Number: 22443
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Sherman <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Comment-Date: Mon, 03 Feb 2025 19:57:18 +0000
Gerrit-HasComments: Yes

Reply via email to