Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22105 )
Change subject: IMPALA-13517: Support overloaded || operator ...................................................................... Patch Set 6: (1 comment) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/22105/6/java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaConcatOrOperator.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaConcatOrOperator.java: http://gerrit.cloudera.org:8080/#/c/22105/6/java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaConcatOrOperator.java@77 PS6, Line 77: private boolean isOrOperand(SqlOperatorBinding opBinding, RelDataType opType, int opNum) { line too long (92 > 90) -- To view, visit http://gerrit.cloudera.org:8080/22105 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iabaf02e84b769db1419bd96e1d1b30b8f83d56f5 Gerrit-Change-Number: 22105 Gerrit-PatchSet: 6 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Tue, 04 Feb 2025 14:56:10 +0000 Gerrit-HasComments: Yes
