Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/22441 )
Change subject: Refactor: Move FileDescriptor, FileBlock and BlockReplica ...................................................................... Patch Set 5: (3 comments) Thanks for taking a look, Daniel and Noemi! http://gerrit.cloudera.org:8080/#/c/22441/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22441/4//COMMIT_MSG@7 PS4, Line 7: FileDescriptor > Would it make sense to call these "HdfsFileDescriptor" etc.? Or are they al well, these are the actual name of the classes I moved. Renaming them isn't the scope of this change. I'll create the new class hierarchy in a follow-up PS. http://gerrit.cloudera.org:8080/#/c/22441/4/fe/src/main/java/org/apache/impala/catalog/BlockReplica.java File fe/src/main/java/org/apache/impala/catalog/BlockReplica.java: http://gerrit.cloudera.org:8080/#/c/22441/4/fe/src/main/java/org/apache/impala/catalog/BlockReplica.java@25 PS4, Line 25: > nit: the Done http://gerrit.cloudera.org:8080/#/c/22441/4/fe/src/main/java/org/apache/impala/catalog/BlockReplica.java@33 PS4, Line 33: ch > Nit: typo (probably in the original). Done -- To view, visit http://gerrit.cloudera.org:8080/22441 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2eb713619d4d231cec65a58255c3ced7b12d1880 Gerrit-Change-Number: 22441 Gerrit-PatchSet: 5 Gerrit-Owner: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Noemi Pap-Takacs <npaptak...@cloudera.com> Gerrit-Comment-Date: Tue, 04 Feb 2025 15:56:31 +0000 Gerrit-HasComments: Yes
