Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/22422 )
Change subject: IMPALA-13703: Cancel running queries before shutdown deadline ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/22422/7/be/src/service/impala-server.h File be/src/service/impala-server.h: http://gerrit.cloudera.org:8080/#/c/22422/7/be/src/service/impala-server.h@1676 PS7, Line 1676: std::atomic_bool shutdown_deadline_cancel_queries_; > I think I missed where we are consuming this? Also, in case cancellation qu I think I see that we're using this atomic to retry query cancellation in the Shutdown Thread. -- To view, visit http://gerrit.cloudera.org:8080/22422 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1cac2e100d329644e21fdceb0b23901b08079130 Gerrit-Change-Number: 22422 Gerrit-PatchSet: 7 Gerrit-Owner: Yida Wu <wydbaggio...@gmail.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Yida Wu <wydbaggio...@gmail.com> Gerrit-Comment-Date: Tue, 04 Feb 2025 21:54:40 +0000 Gerrit-HasComments: Yes
