Surya Hebbar has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21683 )

Change subject: IMPALA-13304: Include aggregate instance-level metrics in JSON 
profile
......................................................................


Patch Set 25:

The expected JSON outputs, and the file names have been fixed. Verified again, 
tests are successful now, it was due to the expected JSON's being switched 
because of naming problems.

Last patchset, it was a nit in clang tidy, for not having 'std' namespace for a 
type declaration.

Hope, the next build is successful.


--
To view, visit http://gerrit.cloudera.org:8080/21683
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I49e18a7a7e1288e3e674e15b6fc86aad60a08214
Gerrit-Change-Number: 21683
Gerrit-PatchSet: 25
Gerrit-Owner: Surya Hebbar <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Kurt Deschler <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Reviewer: Surya Hebbar <[email protected]>
Gerrit-Reviewer: Wenzhe Zhou <[email protected]>
Gerrit-Comment-Date: Thu, 06 Feb 2025 13:05:28 +0000
Gerrit-HasComments: No

Reply via email to