Kurt Deschler has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22367 )

Change subject: IMPALA-13654: Tolerate missing data files of Iceberg tables
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/22367/4/fe/src/main/java/org/apache/impala/catalog/IcebergContentFileStore.java
File fe/src/main/java/org/apache/impala/catalog/IcebergContentFileStore.java:

http://gerrit.cloudera.org:8080/#/c/22367/4/fe/src/main/java/org/apache/impala/catalog/IcebergContentFileStore.java@232
PS4, Line 232:       missingFiles_.add(contentFile.path().toString());
> It's possible, but I'm afraid about the case when there are lots os missing
If I understand you correctly, the messages would have to be serialized so the 
backend could use them. Let's at least make sure that the error message on the 
backend gives enough context like what table it is trying to open a file for.



--
To view, visit http://gerrit.cloudera.org:8080/22367
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If753619d8ee1b30f018e90157ff7bdbe5d7f1525
Gerrit-Change-Number: 22367
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <[email protected]>
Gerrit-Reviewer: Daniel Becker <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Kurt Deschler <[email protected]>
Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
Gerrit-Comment-Date: Thu, 06 Feb 2025 15:24:48 +0000
Gerrit-HasComments: Yes

Reply via email to